-
-
Notifications
You must be signed in to change notification settings - Fork 363
perf(LocalizerString): use FrozenSet improve performance #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR improves the performance of the LocalizerString component by using FrozenSet instead of HashSet in .NET 8 and above. It also refactors the code to improve readability and maintainability. Sequence diagram for localized string retrievalsequenceDiagram
participant Client
participant JsonStringLocalizer
participant CacheManager
Client->>JsonStringLocalizer: Get localized string
JsonStringLocalizer->>CacheManager: GetAllStringsByTypeName()
alt NET 8.0 or greater
CacheManager-->>JsonStringLocalizer: Return FrozenSet
else Earlier versions
CacheManager-->>JsonStringLocalizer: Return HashSet
end
JsonStringLocalizer->>JsonStringLocalizer: GetValueFromCache()
JsonStringLocalizer-->>Client: Return localized value
Class diagram showing the localization data structure changesclassDiagram
class CacheManager {
+GetAllStringsByTypeName(Assembly, string) FrozenSet~LocalizedString~
+GetJsonStringByTypeName(JsonLocalizationOptions, Assembly, string, string?, bool) FrozenSet~LocalizedString~
+GetAllStringsFromResolve(bool) FrozenSet~LocalizedString~
}
class JsonStringLocalizer {
-GetValueFromCache(FrozenSet~LocalizedString~, string) string?
}
note for CacheManager "NET8_0_OR_GREATER: Uses FrozenSet
Other versions: Uses HashSet"
JsonStringLocalizer ..> CacheManager: uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5034 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27961 27951 -10
Branches 4007 4006 -1
=========================================
- Hits 27961 27951 -10 ☔ View full report in Codecov by Sentry. |
use FrozenSet improve performance
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5033
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve the performance of LocalizerString by using FrozenSet.
New Features:
Enhancements: