-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(Drawer): update drawer sample code #5039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the drawer sample code to fix issue #5038. It moves the "Open" button inside a State diagram for drawer component statesstateDiagram-v2
[*] --> Closed
Closed --> Open: Click Open button
Open --> Closed: Click Close button
state Open {
[*] --> WithBackdrop
[*] --> WithoutBackdrop
WithBackdrop --> Resizable: AllowResize=true
WithoutBackdrop --> Resizable: AllowResize=true
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document the purpose of the 'ignore' attribute being added to the section elements - what does it control?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27957 27957
Branches 4006 4006
=========================================
Hits 27957 27957 ☔ View full report in Codecov by Sentry. |
update drawer sample code
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5038
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Documentation: