Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 5, 2025

update drawer sample code

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5038

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Documentation:

  • Updated the drawer sample code.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jan 5, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This PR updates the drawer sample code to fix issue #5038. It moves the "Open" button inside a <section ignore> tag in three different demo blocks within the Drawers.razor file. This change ensures that the button is excluded from automated UI testing.

State diagram for drawer component states

stateDiagram-v2
    [*] --> Closed
    Closed --> Open: Click Open button
    Open --> Closed: Click Close button

    state Open {
        [*] --> WithBackdrop
        [*] --> WithoutBackdrop
        WithBackdrop --> Resizable: AllowResize=true
        WithoutBackdrop --> Resizable: AllowResize=true
    }
Loading

File-Level Changes

Change Details Files
Move "Open" button inside <section ignore> tag
  • Moved the "Open" button within the "Placement" demo block.
  • Moved the "Open" button within the "NoBackdrop" demo block.
  • Moved the "Open" button within the "DrawerService" demo block.
src/BootstrapBlazor.Server/Components/Samples/Drawers.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#5038 Add sample code for Drawer component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 5, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 5, 2025 02:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please document the purpose of the 'ignore' attribute being added to the section elements - what does it control?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fa251c) to head (c3c05b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5039   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          631       631           
  Lines        27957     27957           
  Branches      4006      4006           
=========================================
  Hits         27957     27957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 8407fc6 into main Jan 5, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-drawer branch January 5, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Drawer): update drawer sample code

2 participants