-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(AutoComplete): support Items update #5055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the AutoComplete component to support updating the Items parameter. It changes the initialization logic, filtering behavior, and rendering process to correctly handle changes to the Items. Sequence diagram for AutoComplete filtering processsequenceDiagram
participant User
participant AC as AutoComplete
participant Filter as FilterLogic
User->>AC: Enter text
AC->>Filter: TriggerOnChange(val)
alt has OnCustomFilter
Filter->>Filter: OnCustomFilter(val)
else empty value
Filter->>Filter: Reset to Items.ToList()
else normal filtering
Filter->>Filter: Apply Contains/StartsWith filter
end
Filter-->>AC: Update FilterItems
AC->>User: Show filtered results
Class diagram for AutoComplete component changesclassDiagram
class AutoComplete {
+List<string> Items
-List<string> FilterItems
-List<string> Rows
+bool IgnoreCase
+bool IsLikeMatch
+OnCustomFilter(string)
+TriggerOnChange(string)
#OnParametersSet()
-OnClickItem(string)
}
note for AutoComplete "Changed Items initialization and filtering logic"
State diagram for AutoComplete filtering statesstateDiagram-v2
[*] --> Initial: Initialize
Initial --> Filtered: User Input
Filtered --> CustomFiltered: OnCustomFilter
Filtered --> ResetFilter: Empty Input
Filtered --> NormalFilter: Contains/StartsWith
CustomFiltered --> [*]
ResetFilter --> [*]
NormalFilter --> [*]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5055 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27964 27969 +5
Branches 4008 4010 +2
=========================================
+ Hits 27964 27969 +5 ☔ View full report in Codecov by Sentry. |
support Items update
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5054
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the AutoComplete component to support updating items.
New Features:
Tests: