-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(ComponentLayout): refactor scroll behavior #5091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Zeus <[email protected]> Co-Authored-By: Alex chow <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Reviewer's Guide by SourceryThis PR refactors the scroll behavior of the ComponentLayout component to fix a bug where the page would not scroll to the correct anchor when a hash is present in the URL. The Sequence diagram for updated anchor scroll behaviorsequenceDiagram
participant U as User
participant CL as ComponentLayout
participant JS as JavaScript
participant DOM as Browser DOM
U->>CL: Navigate to URL with hash
activate CL
Note over CL: OnAfterRenderAsync
CL->>JS: InvokeVoidAsync('scrollToAnchor')
activate JS
JS->>JS: Get hash from location
JS->>JS: Decode URI
JS->>JS: Split hash to get anchor
JS->>DOM: Scroll to anchor element
deactivate JS
deactivate CL
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 28084 28084
Branches 4035 4035
=========================================
Hits 28084 28084 ☔ View full report in Codecov by Sentry. |
refactor scroll behavior
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5090
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the scroll behavior of the layout component to scroll to the anchor.
New Features:
Enhancements:
Tests: