-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Watermark): add Watermark component #5099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Watermark component. It includes a JavaScript module for dynamic watermark creation and updates, a C# component for rendering, and integration with existing components and localization. Sequence diagram for Watermark component initialization and updatessequenceDiagram
participant C as Component
participant JS as JavaScript Module
participant Canvas as Canvas API
C->>JS: init(id, options)
JS->>Canvas: Create canvas element
JS->>Canvas: Set font and context
Canvas->>Canvas: Draw watermark text
Canvas-->>JS: Return base64 image
JS->>JS: Create watermark div
JS->>JS: Setup mutation observer
Note over JS: Monitor DOM changes
JS-->>C: Watermark initialized
Note over C,JS: When properties change
C->>JS: update(id, options)
JS->>Canvas: Recreate watermark
Canvas-->>JS: Return new base64 image
JS->>JS: Update watermark div
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 632 633 +1
Lines 28105 28136 +31
Branches 4034 4036 +2
=========================================
+ Hits 28105 28136 +31 ☔ View full report in Codecov by Sentry. |
add Watermark component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5098
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new Watermark component.
New Features:
Tests: