-
-
Notifications
You must be signed in to change notification settings - Fork 365
perf(CacheManager): reduce cache key count #5140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR reduces the number of cache keys used by the Sequence diagram for optimized cache key management in GetJsonStringByTypeNamesequenceDiagram
participant Client
participant CacheManager
participant Cache
Client->>CacheManager: GetJsonStringByTypeName(assembly, typeName, cultureName, forceLoad)
Note over CacheManager: Generate single cache key
alt forceLoad is true
CacheManager->>Cache: Remove(key)
end
critical Lock assembly
CacheManager->>Cache: GetOrCreate(key)
Cache-->>CacheManager: cached sections
Note over CacheManager: Filter items by typeName
end
CacheManager-->>Client: filtered localized items
Class diagram showing CacheManager changesclassDiagram
class CacheManager {
-IMemoryCache Cache
+GetJsonStringByTypeName(Assembly assembly, string typeName, string cultureName, bool forceLoad)
}
class LocalizedString {
+string Key
+string Value
+bool ResourceNotFound
+string SearchedLocation
}
CacheManager ..> LocalizedString : creates
note for CacheManager "Changed to use single cache key
per assembly-culture pair"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Since this is a performance-focused change, please provide some metrics showing the reduction in cache key count and memory usage in a typical application scenario.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28181 28190 +9
Branches 4040 4038 -2
=========================================
+ Hits 28181 28190 +9 ☔ View full report in Codecov by Sentry. |
|
@sourcery-ai review |
reduce cache key count
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5139
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: