-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(MultiSelect): redesign search feature #5162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Alexander Shakhov <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Reviewer's Guide by SourceryThis pull request redesigns the search feature of the MultiSelect component. It introduces a debounce mechanism for the search input, improves keyboard navigation, and enhances the overall user experience. Class diagram for MultiSelect component changesclassDiagram
class MultiSelect {
+string SearchText
+bool ShowSearch
+string SearchLoadingIcon
+Task ConfirmSelectedItem(int index)
+Task TriggerOnSearch(string searchText)
+Task ToggleRow(string value)
-bool _isToggle
}
class MultiSelectJS {
+init(id, invoke, options)
+dispose(id)
-onSearch()
-keydown()
-shown()
-scrollIntoView()
}
MultiSelect --> MultiSelectJS : uses
note for MultiSelectJS "Added debounce and
keyboard navigation"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making null checks consistent throughout the code - some places use
==while others use===. Standardize on===for strict equality checks. - Add error handling for async operations, particularly around the search functionality, to gracefully handle potential failures.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28093 28122 +29
Branches 4039 4043 +4
=========================================
+ Hits 28093 28122 +29 ☔ View full report in Codecov by Sentry. |
redesign search feature
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5159
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign the search feature of the MultiSelect component to improve user experience. Update the search input interaction logic and add a loading icon during searches.
New Features:
Tests: