Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 21, 2025

should show DisplayText when bind-Value in ValidateForm

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5166

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the display of the bound value in a ValidateForm within a BootstrapInputGroupLabel component.

Bug Fixes:

  • Fixed an issue where the display text was not shown when a value was bound in a ValidateForm.

Enhancements:

  • Improved the BootstrapInputGroupLabel component to automatically display the bound value when used inside a ValidateForm.

@bb-auto bb-auto bot added the bug Something isn't working label Jan 21, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

The BootstrapInputGroupLabel component now correctly displays the DisplayText when used with bind-Value in a ValidateForm.

Sequence diagram for BootstrapInputGroupLabel DisplayText resolution

sequenceDiagram
    participant Form as ValidateForm
    participant Label as BootstrapInputGroupLabel
    participant Field as FieldIdentifier

    Form->>Label: Set Parameters
    Label->>Label: OnParametersSet()
    alt IsInnerLabel is true
        Label->>Field: GetDisplayName()
        Field-->>Label: Return display name
        Label->>Label: Set DisplayText if null
    end
Loading

File-Level Changes

Change Details Files
The BootstrapInputGroupLabel component now correctly displays the DisplayText when used with bind-Value in a ValidateForm.
  • Added logic to set DisplayText to the field's display name if DisplayText is null and the component is an inner label.
src/BootstrapBlazor/Components/Input/BootstrapInputGroupLabel.razor.cs
Updated the InputGroups sample to use ShowRequiredMark instead of required.
  • Replaced required="true" with ShowRequiredMark="true" in the BootstrapInputGroupLabel components.
src/BootstrapBlazor.Server/Components/Samples/InputGroups.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#5166 Show DisplayText when bind-Value is used in ValidateForm

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 21, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 21, 2025 02:48
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 21, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (de1b5b1) to head (8cb32d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28145     28149    +4     
  Branches      4049      4051    +2     
=========================================
+ Hits         28145     28149    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang disabled auto-merge January 21, 2025 03:28
@ArgoZhang ArgoZhang merged commit 278aada into main Jan 21, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-label branch January 21, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(BootstrapInputGroupLabel): should show DisplayText when bind-Value in ValidateForm

2 participants