Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 21, 2025

redesign checkbox style compatible InputGroup

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5165

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix checkbox style incompatibility with InputGroup.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

The checkbox style was redesigned to be compatible with the InputGroup component. The checkbox now renders without a surrounding div when used within an InputGroup, and the InputGroup styles were updated to support the checkbox.

Class diagram showing Checkbox component changes

classDiagram
    class Checkbox {
        +Id: string
        +DisplayText: string
        +Required: bool
        +ShowLabelTooltip: bool
        +Disabled: bool
        +StopPropagation: bool
        +IsShowAfterLabel: bool
        +InputGroup: object
        +OnToggleClick(): void
    }
    note for Checkbox "Simplified rendering structure
Removed RenderCheckbox and RenderLabel fragments"
Loading

State diagram for Checkbox rendering states

stateDiagram-v2
    [*] --> CheckboxState
    CheckboxState --> WithLabel: ShowLabel is true
    CheckboxState --> WithoutLabel: ShowLabel is false
    WithLabel --> WithTooltip: ShowLabelTooltip is true
    WithLabel --> WithoutTooltip: ShowLabelTooltip is false
    state CheckboxState {
        [*] --> BaseCheckbox
        BaseCheckbox --> AfterLabel: IsShowAfterLabel is true
    }
Loading

File-Level Changes

Change Details Files
Removed the conditional rendering of the checkbox within a div when used inside an InputGroup.
  • Removed the conditional rendering logic based on the InputGroup property.
  • The checkbox now always renders without a surrounding div.
src/BootstrapBlazor/Components/Checkbox/Checkbox.razor
Updated InputGroup styles to support the checkbox.
  • Added styles for the .form-check class within an InputGroup.
  • The .form-check class now has padding, border, border-radius, flex-grow, width, min-width, display, align-items, and hover styles.
src/BootstrapBlazor/Components/Input/BootstrapInputGroup.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#5165 Ensure correct rendering of TreeView component when placed inside BootstrapInputGroup
#5165 Maintain consistent rendering behavior for dropdown components inside and outside BootstrapInputGroup

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Jan 21, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 21, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed English description of the changes and testing performed. This helps other developers understand and verify the changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (278aada) to head (4769460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28149     28144    -5     
  Branches      4051      4050    -1     
=========================================
- Hits         28149     28144    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit da655c5 into main Jan 21, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-checkbox branch January 21, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(TreeView): 在 BootstrapInputGroup 组件内渲染不正确

2 participants