Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 21, 2025

remove InputGroup cascade parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5169

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the InputGroup cascade parameter from the Slider component.

New Features:

  • Allow direct use of Slider without requiring InputGroup.

Enhancements:

  • Update styles for form-check and form-range inside BootstrapInputGroup to improve alignment and padding.

Tests:

  • Update Sliders sample to reflect the changes and ensure correct rendering.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request removes the InputGroup cascade parameter from the Slider component, simplifying its structure and styling.

Class diagram showing Slider component changes

classDiagram
    class Slider {
        -string Id
        -string ClassString
        -bool IsDisabled
        -string CurrentValueAsString
        -string EventString
        -string StepString
        -string MinString
        -string MaxString
        -string DisplayText
        -bool ShowLabelTooltip
        +OnBlur()
    }
    note for Slider "Removed InputGroup parameter
and simplified rendering logic"
Loading

File-Level Changes

Change Details Files
Removed the InputGroup cascade parameter from the Slider component.
  • Removed conditional rendering based on the InputGroup parameter.
  • The Slider component now always renders the range input directly.
src/BootstrapBlazor/Components/Slider/Slider.razor
Removed the custom styling for the Slider when it is inside an InputGroup.
  • Removed the .range-group class and its associated styles.
  • Removed the height definition for the form-range class.
src/BootstrapBlazor/Components/Slider/Slider.razor.scss
Adjusted the styling of form-check and form-range elements within the InputGroup.
  • Added display: flex and align-items: center to .form-check elements.
  • Added height and padding to .form-range elements.
  • Moved shared styles for .form-check and .form-range into a common selector.
src/BootstrapBlazor/Components/Input/BootstrapInputGroup.razor.scss
Updated the Slider samples to reflect the removal of the InputGroup cascade parameter.
  • Removed the conditional rendering of the Slider based on whether it is inside an InputGroup.
  • The Slider component is now always rendered directly.
src/BootstrapBlazor.Server/Components/Samples/Sliders.razor
Removed the form-range-height variable.
  • Removed the $bb-form-range-height variable.
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#5169 Remove InputGroup cascade parameter from Slider component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 21, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 21, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (da655c5) to head (7c84917).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28144     28139    -5     
  Branches      4050      4049    -1     
=========================================
- Hits         28144     28139    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 1c0f564 into main Jan 21, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-range branch January 21, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Slider): remove InputGroup cascade parameter

2 participants