-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Slider): remove InputGroup cascade parameter #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request removes the InputGroup cascade parameter from the Slider component, simplifying its structure and styling. Class diagram showing Slider component changesclassDiagram
class Slider {
-string Id
-string ClassString
-bool IsDisabled
-string CurrentValueAsString
-string EventString
-string StepString
-string MinString
-string MaxString
-string DisplayText
-bool ShowLabelTooltip
+OnBlur()
}
note for Slider "Removed InputGroup parameter
and simplified rendering logic"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28144 28139 -5
Branches 4050 4049 -1
=========================================
- Hits 28144 28139 -5 ☔ View full report in Codecov by Sentry. |
remove InputGroup cascade parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5169
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the
InputGroupcascade parameter from theSlidercomponent.New Features:
Sliderwithout requiringInputGroup.Enhancements:
form-checkandform-rangeinsideBootstrapInputGroupto improve alignment and padding.Tests:
Sliderssample to reflect the changes and ensure correct rendering.