-
-
Notifications
You must be signed in to change notification settings - Fork 365
refactor(QueryPageOptions): rename paramater IsTriggerPagination #5195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request renames the Sequence diagram showing the query data flow with renamed propertysequenceDiagram
participant Table
participant QueryPageOptions
Table->>Table: QueryData(triggerByPagination)
Table->>QueryPageOptions: BuildQueryPageOptions()
Note over QueryPageOptions: Set IsTriggerByPagination
Note over QueryPageOptions: (formerly TriggerByPagination)
Class diagram showing the renamed property in QueryPageOptionsclassDiagram
class QueryPageOptions {
-bool IsTriggerByPagination
+bool getIsTriggerByPagination()
+void setIsTriggerByPagination(bool)
}
note for QueryPageOptions "Property renamed from TriggerByPagination"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a typo in the PR title and description: 'paramater' should be 'parameter'
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28169 28169
Branches 4053 4053
=========================================
Hits 28169 28169 ☔ View full report in Codecov by Sentry. |
rename paramater IsTriggerPagination
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5194
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Rename the
TriggerByPaginationparameter toIsTriggerByPaginationin theQueryPageOptionsclass.Enhancements:
Tests: