Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 24, 2025

rename paramater IsTriggerPagination

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5194

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Rename the TriggerByPagination parameter to IsTriggerByPagination in the QueryPageOptions class.

Enhancements:

  • Standardize parameter naming by adding "Is" prefix.

Tests:

  • Update tests to reflect the parameter name change.

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 24, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 24, 2025

Reviewer's Guide by Sourcery

This pull request renames the TriggerByPagination property to IsTriggerByPagination in the QueryPageOptions class and updates its usage in the Table component and related unit tests.

Sequence diagram showing the query data flow with renamed property

sequenceDiagram
    participant Table
    participant QueryPageOptions
    Table->>Table: QueryData(triggerByPagination)
    Table->>QueryPageOptions: BuildQueryPageOptions()
    Note over QueryPageOptions: Set IsTriggerByPagination
    Note over QueryPageOptions: (formerly TriggerByPagination)
Loading

Class diagram showing the renamed property in QueryPageOptions

classDiagram
    class QueryPageOptions {
        -bool IsTriggerByPagination
        +bool getIsTriggerByPagination()
        +void setIsTriggerByPagination(bool)
    }
    note for QueryPageOptions "Property renamed from TriggerByPagination"
Loading

File-Level Changes

Change Details Files
Renamed TriggerByPagination to IsTriggerByPagination in QueryPageOptions.
  • Renamed the TriggerByPagination property to IsTriggerByPagination.
src/BootstrapBlazor/Options/QueryPageOptions.cs
Updated the Table component to use the new IsTriggerByPagination property.
  • Replaced queryOption.TriggerByPagination with queryOption.IsTriggerByPagination.
src/BootstrapBlazor/Components/Table/Table.razor.Edit.cs
Updated unit tests to use the new IsTriggerByPagination property.
  • Replaced option.TriggerByPagination with option.IsTriggerByPagination.
test/UnitTest/Components/TableTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5194 Rename the parameter 'TriggerByPagination' to 'IsTriggerByPagination'

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 24, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 24, 2025 05:25
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a typo in the PR title and description: 'paramater' should be 'parameter'
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c607323) to head (ae9cfb6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28169     28169           
  Branches      4053      4053           
=========================================
  Hits         28169     28169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 7b1a2f2 into main Jan 24, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-table-p branch January 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(QueryPageOptions): rename paramater IsTriggerPagination

2 participants