-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(Dropdown): custom content use ButtonTemplate #5196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new ButtonTemplate feature to the Dropdown component, allowing for custom button content. It also includes minor updates to the sample page, adding a new demo for the ButtonTemplate feature and updating existing Dropdown usages to self-close. Class diagram showing Dropdown component changesclassDiagram
class Dropdown {
+TValue Value
+IEnumerable<TValue> Items
+bool IsFixedButtonText
+string FixedButtonText
+RenderFragment ButtonTemplate
}
note for Dropdown "Added ButtonTemplate for custom content"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please include the localization changes for en-US.json and zh-CN.json files to support the new ButtonTemplate feature
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28169 28169
Branches 4053 4053
=========================================
Hits 28169 28169 ☔ View full report in Codecov by Sentry. |
custom content use ButtonTemplate
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5189
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge