-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(Modal): use TrySetResult prevent throw exception
#5222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe pull request modifies the ModalDialog component to use Sequence diagram for Modal Dialog closing processsequenceDiagram
participant C as Client
participant MD as ModalDialog
participant MT as Modal Task
C->>MD: Close Modal
activate MD
MD->>MT: TrySetResult(result)
Note right of MT: Safely sets result without throwing
MD->>MD: Modal.Close()
MD-->>C: Modal Closed
deactivate MD
State diagram for Modal Dialog Result TaskstateDiagram-v2
[*] --> Pending
Pending --> Completed: TrySetResult
Completed --> [*]
note right of Completed: Using TrySetResult prevents
note right of Completed: exceptions if already completed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR template completely, including the Risk level and Regression status. This helps reviewers better understand the impact of the change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 635 635
Lines 28243 28243
Branches 4066 4066
=========================================
Hits 28243 28243 ☔ View full report in Codecov by Sentry. |
use
TrySetResultprevent throw exceptionSummary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5221
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: