Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 27, 2025

can resize the fixed column

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #3447

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable resizing for fixed columns in tables.

New Features:

  • Allow users to resize the width of fixed columns in tables.

Tests:

  • Updated tests to cover the new resizing feature for fixed columns.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2025

Reviewer's Guide by Sourcery

This pull request enables resizing of fixed columns in the Table component. It introduces a new function to handle the resizing of adjacent fixed columns and modifies the existing resize logic to call this new function.

Sequence diagram for fixed column resizing interaction

sequenceDiagram
    participant User
    participant Table
    participant ResizeHandler
    participant FixedColumns

    User->>Table: Drags column resizer
    Table->>ResizeHandler: Trigger resize event
    ResizeHandler->>ResizeHandler: Calculate new width
    ResizeHandler->>Table: Update column width
    alt Is Fixed Column
        ResizeHandler->>FixedColumns: Call resizeNextFixedColumnWidth
        FixedColumns->>FixedColumns: Update adjacent fixed columns
    end
    Table->>User: Display updated column widths
Loading

Class diagram for Table component with resizing feature

classDiagram
    class Table {
        +AllowResizing: bool
        +RenderMode: TableRenderMode
        +setResizeListener()
        +setColumnResizingListen()
    }

    class TableColumn {
        +Field: string
        +Width: int
        +Fixed: bool
        +Filterable: bool
    }

    class ResizeHandler {
        +resizeNextFixedColumnWidth(col, width)
        -handleFixedRight()
        -handleFixed()
    }

    Table *-- TableColumn
    Table --> ResizeHandler
Loading

File-Level Changes

Change Details Files
Added logic to resize adjacent fixed columns when resizing a fixed column.
  • Added a new function resizeNextFixedColumnWidth to handle resizing of adjacent fixed columns.
  • Modified the setResizeListener function to call resizeNextFixedColumnWidth when a fixed column is resized.
  • Adjusted the width calculation to use setProperty instead of direct assignment.
src/BootstrapBlazor/Components/Table/Table.razor.js
Modified the Table component to allow resizing of fixed columns.
  • Removed the condition that prevents resizing of fixed columns.
src/BootstrapBlazor/Components/Table/Table.razor
Updated the demo page to showcase the new resizing feature.
  • Added AllowResizing=true to the Table component.
  • Added more fixed columns to the demo table.
src/BootstrapBlazor.Server/Components/Samples/Table/TablesFixedColumn.razor
Updated the table style to prevent content overflow.
  • Added overflow: hidden to the td > .table-cell style.
src/BootstrapBlazor/Components/Table/Table.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#3447 Enable resizing of fixed columns in the Table component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 27, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Jan 27, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider optimizing the column resize handler for large tables - updating individual cell styles for every row could impact performance. Consider batching updates or using a more efficient approach like CSS classes.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e132a9) to head (bf92392).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       635           
  Lines        28243     28243           
  Branches      4066      4066           
=========================================
  Hits         28243     28243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 175dac6 into main Jan 27, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch January 27, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): can resize the fixed column

2 participants