-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(LoadModeByName): add LoadModuleByName extension method #5286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/BootstrapBlazor/Services/WebClientService.cs
# Conflicts: # src/BootstrapBlazor/Services/WebClientService.cs
Reviewer's Guide by SourceryThis pull request introduces a new extension method Sequence diagram showing the simplified module loading processsequenceDiagram
participant Service as Service Class
participant Extensions as JSModuleExtensions
participant Runtime as IJSRuntime
participant Module as JSModule
Service->>Extensions: LoadModuleByName('moduleName')
Extensions->>Extensions: Construct module path
Note right of Extensions: ./_content/BootstrapBlazor/modules/{name}.js
Extensions->>Runtime: LoadModule(fileName)
Runtime-->>Service: JSModule instance
Class diagram showing the new LoadModuleByName extension methodclassDiagram
class JSModuleExtensions {
+LoadUtility(IJSRuntime jsRuntime, string? version) Task~JSModule~
+LoadModuleByName(IJSRuntime jsRuntime, string moduleName, string? version) Task~JSModule~
+LoadModule(IJSRuntime jsRuntime, string fileName, string? version) Task~JSModule~
}
class IJSRuntime {
<<interface>>
}
class JSModule {
<<class>>
}
JSModuleExtensions ..> IJSRuntime : extends
JSModuleExtensions ..> JSModule : returns
note for JSModuleExtensions "New LoadModuleByName method
Simplifies module loading by name"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding logging capability to LoadModuleByName method to maintain visibility into module loading operations, rather than removing it entirely
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 640 640
Lines 28782 28781 -1
Branches 4090 4090
=========================================
- Hits 28782 28781 -1 ☔ View full report in Codecov by Sentry. |
add LoadModuleByName extension method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5285
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce the
LoadModuleByNameextension method to simplify loading JS modules.New Features:
LoadModuleByNameextension method to theIJSRuntimethat simplifies loading JavaScript modules by automatically constructing the module path.Tests:
LoadModulewithLoadModuleByNameacross the project.