-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(ListView): add EmptyText parameter #5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces an EmptyText parameter to the ListView component, allowing users to display a message or template when the list is empty. Additionally, it refactors the JS module loading logic to use a new LoadModuleByName extension method. Sequence diagram for ListView rendering logicsequenceDiagram
participant C as Component
participant L as ListView
C->>L: Render
alt Rows.Count > 0
alt BodyTemplate exists
L->>L: Render items with BodyTemplate
end
else Rows empty
alt EmptyTemplate exists
L->>L: Render EmptyTemplate
else
L->>L: Display EmptyText
end
end
Class diagram for ListView component changesclassDiagram
class ListView {
+RenderFragment? EmptyTemplate
+string? EmptyText
+RenderFragment? BodyTemplate
+string? GroupName
+bool Collapsible
+bool IsAccordion
+OnClick(item)
}
note for ListView "Added EmptyTemplate and EmptyText parameters"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-Authored-By: caics <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 640 640
Lines 28781 28791 +10
Branches 4090 4092 +2
=========================================
+ Hits 28781 28791 +10 ☔ View full report in Codecov by Sentry. |
add EmptyText parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5279
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: