-
-
Notifications
You must be signed in to change notification settings - Fork 364
doc(CacheList): rename CacheExpiration component #5314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request renames the CacaheExpiration component to CacheExpiration and moves it to a more appropriate directory. It also initializes the _cacheList field. Class diagram showing the renamed CacheExpiration componentclassDiagram
class CacheExpiration {
+ICacheEntry Entry
}
note for CacheExpiration "Renamed from CacaheExpiration
Moved from Pages to Components namespace"
class CacheList {
-List~object~ _cacheList
+IStringLocalizer~CacheList~ Localizer
}
CacheList --> CacheExpiration : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Ensure that moving CacheExpiration to the new 'Components' namespace is reflected consistently across the project and fits the overall naming conventions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 28922 28922
Branches 4111 4111
=========================================
Hits 28922 28922 ☔ View full report in Codecov by Sentry. |
rename CacheExpiration component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5313
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Rename the
CacaheExpirationcomponent toCacheExpiration.Bug Fixes:
Chores:
CacheExpirationcomponent toComponentsnamespace.