-
-
Notifications
You must be signed in to change notification settings - Fork 365
test(Dropdown): add unit test improve code coverage #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds unit tests to improve code coverage for the Dropdown component's split button functionality and updates the markup implementation to enhance clarity and functionality. Sequence Diagram for Dropdown Split Button TestsequenceDiagram
actor Tester as UnitTest
participant Dropdown as Dropdown Component
participant DynamicElement as Rendered DynamicElement
Tester->>Dropdown: Simulate click on split button
Dropdown->>DynamicElement: Render <DynamicElement TagName="button">
DynamicElement-->>Dropdown: Trigger OnClick event
Dropdown-->>Tester: Handle click event & update state
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5323 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 28922 28934 +12
Branches 4111 4113 +2
=========================================
+ Hits 28922 28934 +12 ☔ View full report in Codecov by Sentry. |
add unit test improve code coverage
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5320
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Tests:
Dropdowncomponent.