Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 11, 2025

ScrollWidth parameter not work

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5343

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix the issue where the ScrollWidth parameter was not working correctly.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

The PR addresses the bug where the ScrollWidth parameter was not functioning. It implements the fix by adding explicit ScrollWidth and ScrollHoverWidth attributes on sample tables, modifying the Table component's markup to conditionally set the scroll styles, and updating the backend logic to compute the appropriate style string.

Updated class diagram for Table component with ScrollWidth fixes

classDiagram
    class Table {
        +string? GetScrollStyleString(bool condition)
        +int ActualScrollWidth
        +int ActualScrollHoverWidth
        +string WrapperClassName
        +void RenderTable(bool fixedHeader)
        +void RenderHeader(bool fixedHeader)
    }

    note for Table "Added GetScrollStyleString method to conditionally return the scroll style string based on the header type.\nAlso, new attributes ScrollWidth and ScrollHoverWidth are applied in the sample usage."
Loading

File-Level Changes

Change Details Files
Added explicit scroll attribute values in the sample table markup
  • Updated sample table declarations to include ScrollWidth and ScrollHoverWidth properties
  • Ensured consistent display behavior for fixed header table samples
src/BootstrapBlazor.Server/Components/Samples/Table/TablesFixedColumn.razor
Modified Table component markup to conditionally apply scroll styles
  • Changed the wrapper div to include a style attribute using GetScrollStyleString
  • Updated div for fixed table body to call GetScrollStyleString with a true condition for fixed headers
src/BootstrapBlazor/Components/Table/Table.razor
Refactored scroll style computation in the Table component code-behind
  • Removed the direct ScrollStyleString property
  • Introduced GetScrollStyleString method that returns a style string based on a boolean flag
  • Ensured that the actual scroll width values are used if provided, otherwise using the default options
src/BootstrapBlazor/Components/Table/Table.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5343 Implement ScrollWidth parameter functionality for Table component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Feb 11, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 11, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the ternary operator and just setting the style to null when IsFixedHeader is true.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (92091df) to head (e3e9aea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5344   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          644       644           
  Lines        28925     28927    +2     
  Branches      4122      4123    +1     
=========================================
+ Hits         28925     28927    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 97fb12c into main Feb 11, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-table-scroll branch February 11, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): ScrollWidth parameter not work

2 participants