-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(Table): ScrollWidth parameter not work #5344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR addresses the bug where the ScrollWidth parameter was not functioning. It implements the fix by adding explicit ScrollWidth and ScrollHoverWidth attributes on sample tables, modifying the Table component's markup to conditionally set the scroll styles, and updating the backend logic to compute the appropriate style string. Updated class diagram for Table component with ScrollWidth fixesclassDiagram
class Table {
+string? GetScrollStyleString(bool condition)
+int ActualScrollWidth
+int ActualScrollHoverWidth
+string WrapperClassName
+void RenderTable(bool fixedHeader)
+void RenderHeader(bool fixedHeader)
}
note for Table "Added GetScrollStyleString method to conditionally return the scroll style string based on the header type.\nAlso, new attributes ScrollWidth and ScrollHoverWidth are applied in the sample usage."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the ternary operator and just setting the style to null when
IsFixedHeaderis true.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 28925 28927 +2
Branches 4122 4123 +1
=========================================
+ Hits 28925 28927 +2 ☔ View full report in Codecov by Sentry. |
ScrollWidth parameter not work
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5343
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes:
ScrollWidthparameter was not working correctly.