-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(TextArea): add UseShiftEnter parameter #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR introduces an asynchronous callback for keyboard events by adding an OnKeyUpAsync parameter and updating the Textarea component to handle keyup events. The changes include parameter declaration, event binding, and method implementation for handling keys. Sequence diagram for Textarea KeyUp event handlingsequenceDiagram
participant Browser as Browser
participant TA as Textarea
Browser->>TA: KeyUp Event (KeyboardEventArgs)
TA->>TA: OnKeyUp(KeyboardEventArgs)
alt Key == "Enter"
TA-->>TA: Invoke OnEnterAsync(Value)
else Key == "Escape"
TA-->>TA: Invoke OnEscAsync(Value)
end
alt OnKeyUpAsync present
TA->>TA: await OnKeyUpAsync(KeyboardEventArgs)
end
TA-->>Browser: Event handled
Updated class diagram for Textarea componentclassDiagram
class Textarea {
+bool IsAutoScroll
+Func<KeyboardEventArgs,Task>? OnKeyUpAsync
-async Task OnKeyUp(KeyboardEventArgs args)
// Other existing properties and methods not shown
}
note for Textarea "Added asynchronous keyup callback support via OnKeyUpAsync and event binding"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the key check logic in
OnKeyUpto a separate method for better readability. - It might be helpful to include a brief description of the intended use case for the
OnKeyUpAsyncparameter in the component's documentation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29210 29212 +2
Branches 4124 4125 +1
=========================================
+ Hits 29210 29212 +2 ☔ View full report in Codecov by Sentry. |
add OnKeyUpAsync parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5315
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
OnKeyUpAsyncparameter to theTextAreacomponent. This parameter allows developers to specify a callback function that will be invoked when the user releases a key while the textarea is focused.