-
-
Notifications
You must be signed in to change notification settings - Fork 364
chore(Tools): update maintenance tools #5355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the maintenance tools by adding new, centralized scripts for cleaning, packaging, and monitoring the project and removes outdated scripts from previous tool directories. Flow diagram for packaging and monitoring scripts (pack.bat & watch.bat)flowchart TD
subgraph Pack_Script [pack.bat]
A1[Start pack.bat] --> B1[cd ../src/BootstrapBlazor]
B1 --> C1[Run: dotnet pack -c Release]
C1 --> D1[End pack.bat]
end
subgraph Watch_Script [watch.bat]
A2[Start watch.bat] --> B2[cd ../src/BootstrapBlazor.Server]
B2 --> C2[Run: dotnet watch run]
C2 --> D2[End watch.bat]
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding comments to the batch scripts to explain their purpose and usage.
- It might be helpful to add error handling to the batch scripts.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5355 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29212 29212
Branches 4125 4125
=========================================
Hits 29212 29212 ☔ View full report in Codecov by Sentry. |
update maintenance tools
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5354
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce scripts for deleting bin/obj folders, packing the BootstrapBlazor project, and watching for changes in BootstrapBlazor.Server.
Build:
Chores: