-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(TextArea): support OnEnteryAsync/OnEscAsync parameter #5357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR introduces asynchronous event support for the TextArea component by adding OnEnterAsync and OnEscAsync parameters. The implementation includes updating sample pages to demonstrate the new key event functionality, adjusting component attributes for proper JS interop, and minor locale updates. Sequence diagram for TextArea async key eventssequenceDiagram
actor User
participant TextArea
participant SampleComponent
participant ConsoleLogger
User->>TextArea: Press Enter key
TextArea->>SampleComponent: Invoke OnEnterAsync(val)
SampleComponent->>ConsoleLogger: Log "Trigger Enter Key Event"
User->>TextArea: Press Esc key
TextArea->>SampleComponent: Invoke OnEscAsync(val)
SampleComponent->>ConsoleLogger: Log "Trigger Esc Key Event"
Updated class diagram for TextAreas sample componentclassDiagram
class TextAreasSampleComponent {
+ConsoleLogger ConsoleLogger
+Task OnEnterAsync(string val)
+Task OnEscAsync(string val)
+void MockChat()
}
class ConsoleLogger {
+void Log(string message)
}
TextAreasSampleComponent --> ConsoleLogger : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a debounce to the OnEnterAsync and OnEscAsync events to prevent excessive calls.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29212 29212
Branches 4125 4125
=========================================
Hits 29212 29212 ☔ View full report in Codecov by Sentry. |
support OnEnteryAsync/OnEscAsync parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5356
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
OnEnterAsyncandOnEscAsyncparameters to theTextAreacomponent.