Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 15, 2025

add sample code for AutoSelectFirstWhenValueIsNull

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5364

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add sample code for the AutoSelectFirstWhenValueIsNull parameter in the RadioList component and fix the issue where the first item was not selected when the value was null.

Bug Fixes:

  • Fix issue where RadioList component would not select the first item when the value is null and AutoSelectFirstWhenValueIsNull is set to true.

Documentation:

  • Add sample code demonstrating the usage of the AutoSelectFirstWhenValueIsNull parameter for the RadioList component.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 15, 2025

Reviewer's Guide by Sourcery

This pull request adds a new demo to the RadioList component showcasing the AutoSelectFirstWhenValueIsNull feature. It also updates the documentation to include the new property.

Updated class diagram for Radios component

classDiagram
  class Radios {
    -IEnumerable~SelectedItem~ DemoValues
    -IEnumerable~SelectedItem~ AutoSelectValues
    -IEnumerable~SelectedItem~ DisableValues
    +OnInitialized()
    +GetAttributes()
  }
  Radios -- SelectedItem : has
  note for Radios "Added AutoSelectValues property and updated OnInitialized method to include AutoSelectValues"
Loading

File-Level Changes

Change Details Files
Added a new demo showcasing the AutoSelectFirstWhenValueIsNull feature of the RadioList component.
  • Added AutoSelectValues property to the Radios.razor.cs file.
  • Added a new DemoBlock in Radios.razor to demonstrate the AutoSelectFirstWhenValueIsNull feature.
  • Added localization resources for the new demo in both en-US.json and zh-CN.json.
src/BootstrapBlazor.Server/Components/Samples/Radios.razor.cs
src/BootstrapBlazor.Server/Components/Samples/Radios.razor
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json
Added a new attribute to the GetAttributes method in Radios.razor.cs.
  • Added a new AttributeItem for the AutoSelectFirstWhenValueIsNull property.
  • Added description and default value for the AutoSelectFirstWhenValueIsNull property.
src/BootstrapBlazor.Server/Components/Samples/Radios.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5364 Enable the Radio component to support a 'no one checked' state when the TValue is nullable and the value is null. The PR only adds documentation and sample code for the AutoSelectFirstWhenValueIsNull property. It does not modify the Radio component to allow for a 'no one checked' state when the value is null. The sample code demonstrates how to use the AutoSelectFirstWhenValueIsNull property, but it doesn't address the core issue of supporting a nullable value resulting in no selection.
#5364 Provide a way to display a radio button group with no default selection when the bound value is null. The PR adds documentation and a demo, but does not change the underlying component to allow a null value to result in no selection. The demo shows how to prevent auto-selection, but not how to handle a null value to achieve the desired 'no one checked' state.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 15, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 15, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a code snippet to the demo to showcase the AutoSelectFirstWhenValueIsNull functionality.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) February 15, 2025 05:39
@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6616a6f) to head (ef79377).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5367   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          644       644           
  Lines        29218     29218           
  Branches      4125      4125           
=========================================
  Hits         29218     29218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 8f92817 into main Feb 15, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-radio branch February 15, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(radio): support no one checked state

2 participants