-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(RadioList): add sample code for AutoSelectFirstWhenValueIsNull #5367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a new demo to the RadioList component showcasing the Updated class diagram for Radios componentclassDiagram
class Radios {
-IEnumerable~SelectedItem~ DemoValues
-IEnumerable~SelectedItem~ AutoSelectValues
-IEnumerable~SelectedItem~ DisableValues
+OnInitialized()
+GetAttributes()
}
Radios -- SelectedItem : has
note for Radios "Added AutoSelectValues property and updated OnInitialized method to include AutoSelectValues"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a code snippet to the demo to showcase the
AutoSelectFirstWhenValueIsNullfunctionality.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5367 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29218 29218
Branches 4125 4125
=========================================
Hits 29218 29218 ☔ View full report in Codecov by Sentry. |
add sample code for AutoSelectFirstWhenValueIsNull
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5364
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add sample code for the
AutoSelectFirstWhenValueIsNullparameter in theRadioListcomponent and fix the issue where the first item was not selected when the value was null.Bug Fixes:
Documentation:
AutoSelectFirstWhenValueIsNullparameter for theRadioListcomponent.