-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(ButtonUpload): add FileCount parameter #5371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider if
FileCountshould be nullable to differentiate between a single file upload and multiple files when the count is not explicitly provided. - The added test case only checks the file count when
IsDirectoryis true; consider adding a test case when it is false or not set.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5371 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29218 29220 +2
Branches 4125 4125
=========================================
+ Hits 29218 29220 +2 ☔ View full report in Codecov by Sentry. |
add FileCount parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5329
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add
FileCountparameter toUploadFileclass and updateButtonUploadcomponent to use it.New Features:
FileCountparameter to theUploadFileclass to track the number of uploaded files.Bug Fixes:
Tests:
ButtonUploadcomponent to verify theFileCountparameter.