Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 15, 2025

add FileCount parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5329

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add FileCount parameter to UploadFile class and update ButtonUpload component to use it.

New Features:

  • Add a FileCount parameter to the UploadFile class to track the number of uploaded files.

Bug Fixes:

Tests:

  • Add a test case for the ButtonUpload component to verify the FileCount parameter.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 15, 2025

Reviewer's Guide by Sourcery

This pull request introduces a FileCount parameter to the ButtonUpload component, allowing users to track the number of files uploaded. A unit test was also added to verify the functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a FileCount property to the UploadFile class to track the number of files uploaded.
  • Added a FileCount property with a default value of 1.
  • The FileCount property is initialized in ButtonUploadBase.cs with the value of args.FileCount from the InputFileChangeEventArgs.
src/BootstrapBlazor/Components/Upload/UploadFile.cs
src/BootstrapBlazor/Components/Upload/ButtonUploadBase.cs
Added a unit test to verify the FileCount property when uploading directories.
  • Added a new test case ButtonUpload_IsDirectory_Ok to check the FileCount property.
  • Assert that the FileCount property is equal to the number of files when a directory is uploaded.
test/UnitTest/Components/UploadTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5329 Provide a way to access the number of files selected in the ButtonUpload component when IsMultiple is set to true.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 15, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 15, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider if FileCount should be nullable to differentiate between a single file upload and multiple files when the count is not explicitly provided.
  • The added test case only checks the file count when IsDirectory is true; consider adding a test case when it is false or not set.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9962e19) to head (4758ed6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5371   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          644       644           
  Lines        29218     29220    +2     
  Branches      4125      4125           
=========================================
+ Hits         29218     29220    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 8a5e79c into main Feb 15, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-upload branch February 15, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ButtonUpload): 多选文件后,无法取到选择的文件个数

2 participants