-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(Dropdown): add sample code for ItemTemplate #5374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a new sample to the documentation demonstrating the usage of the Sequence diagram for rendering Dropdown with ItemTemplatesequenceDiagram
participant Dropdown Component
participant ItemTemplate
participant Tooltip Component
Dropdown Component->>ItemTemplate: For each item
ItemTemplate->>Tooltip Component: Render Tooltip with item data
Tooltip Component-->>ItemTemplate: Returns rendered item
ItemTemplate-->>Dropdown Component: Returns rendered item
Dropdown Component->>Dropdown Component: Display item in dropdown
Updated class diagram for the Dropdown componentclassDiagram
class Dropdown {
+RenderFragment ItemTemplate
}
Dropdown : +renders items via ItemTemplate
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a screenshot of the new Dropdown ItemTemplate example to the pull request description.
- The added CSS rule seems overly specific; consider if a more general rule would suffice.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29220 29218 -2
Branches 4125 4125
=========================================
- Hits 29220 29218 -2 ☔ View full report in Codecov by Sentry. |
add sample code for ItemTemplate
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5373
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add
ItemTemplateto theDropdowncomponent to allow customization of dropdown items. Include a sample code in the documentation to demonstrate its usage. Fix the alignment of dropdown item content within the tooltip.New Features:
ItemTemplateproperty to theDropdowncomponent to support custom item renderingBug Fixes:
Documentation:
ItemTemplateinDropdowncomponent