-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Step): Prev Next function return step index #5376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe Sequence diagram for the Prev methodsequenceDiagram
participant Step
Step->>Step: _currentStepIndex = Math.Max(0, _currentStepIndex - 1)
Step->>Step: StateHasChanged()
Step-->>Step: return _currentStepIndex
Sequence diagram for the Next methodsequenceDiagram
participant Step
Step->>Step: _currentStepIndex = Math.Min(Items.Count, _currentStepIndex + 1)
alt IsFinished && OnFinishedCallback != null
Step->>Step: await OnFinishedCallback()
end
Step->>Step: StateHasChanged()
Step-->>Step: return _currentStepIndex
Updated class diagram for the Step componentclassDiagram
class Step {
-int _currentStepIndex
+List~StepItem~ Items
+bool IsFinished
+Func~Task~ OnFinishedCallback
+void Prev()
+Task Next()
+void Reset()
}
Step -- StepItem : Contains
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider whether the return value of
PrevandNextis actually useful to callers.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5376 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29218 29220 +2
Branches 4125 4125
=========================================
+ Hits 29218 29220 +2 ☔ View full report in Codecov by Sentry. |
Prev Next function return step index
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5372
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the step component to return the current step index when moving between steps. Add a reset method to reset the step to its initial state.
Bug Fixes:
PrevNextfunction return step index #5372Enhancements:
NextandPrevmethods to return the current step index after the step change.NextandPrevmethods to better reflect their updated functionality.Resetmethod to reset the step to the initial state