Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 17, 2025

add ContextMenuDivider component

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5378

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add the ContextMenuDivider component. This component visually separates groups of items within a context menu, enhancing usability.

New Features:

  • Introduce ContextMenuDivider component to allow adding a divider between context menu items.

Tests:

  • Add unit test for the ContextMenuDivider component.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 17, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new ContextMenuDivider component to the BootstrapBlazor library. This component allows developers to add visual dividers within the ContextMenu component, improving the structure and readability of context menus.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduces the ContextMenuDivider component, which inherits from Divider and implements IContextMenuItem. It renders a divider within a ContextMenu.
  • Created a new ContextMenuDivider component.
  • The component inherits from the Divider component.
  • The component implements the IContextMenuItem interface.
  • The component registers itself with the parent ContextMenu on initialization.
  • The component removes itself from the parent ContextMenu when disposed.
src/BootstrapBlazor/Components/ContextMenu/ContextMenuDivider.cs
Adds an interface IContextMenuItem to represent items that can be added to a ContextMenu.
  • Created a new interface IContextMenuItem.
  • The interface is an empty interface used as a marker for context menu items.
src/BootstrapBlazor/Components/ContextMenu/IContextMenuItem.cs
Updates the ContextMenu component to support ContextMenuDivider components.
  • Modified the ContextMenu component to accept IContextMenuItem instead of ContextMenuItem.
  • Modified the ContextMenu component to render ContextMenuDivider components.
  • Modified the AddItem and RemoveItem methods to accept IContextMenuItem.
src/BootstrapBlazor/Components/ContextMenu/ContextMenu.razor
src/BootstrapBlazor/Components/ContextMenu/ContextMenu.razor.cs
Updates the ContextMenuItem to implement the IContextMenuItem interface.
  • Modified the ContextMenuItem component to implement IContextMenuItem.
src/BootstrapBlazor/Components/ContextMenu/ContextMenuItem.cs
Adds a unit test for the ContextMenuDivider component.
  • Added a new unit test to verify the rendering of the ContextMenuDivider component.
test/UnitTest/Components/ContextMenuTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5378 Add a ContextMenuDivider component to the BootstrapBlazor component library.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 17, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (19f6dfe) to head (359c0c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          644       645    +1     
  Lines        29220     29246   +26     
  Branches      4125      4129    +4     
=========================================
+ Hits         29220     29246   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 9f3214b into main Feb 17, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-divider branch February 17, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ContextMenuDivider): add ContextMenuDivider component

2 participants