-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Drawer): add ZIndex parameter #5396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a constant for the default ZIndex value instead of
null. - The CSS style should be added via
CssBuilderrather than string concatenation.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5396 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29269 29276 +7
Branches 4134 4135 +1
=========================================
+ Hits 29269 29276 +7 ☔ View full report in Codecov by Sentry. |
add ZIndex parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5395
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request introduces a
ZIndexparameter to theDrawercomponent, allowing developers to control the stacking order of drawers. It also adds a corresponding property to theDrawerOptionclass for use with theDrawerContainerand includes a unit test for the new parameter.New Features:
ZIndexparameter to theDrawercomponent to allow users to control the stacking order of the drawer.Enhancements:
DrawerOptionclass now includes aZIndexproperty to allow setting the z-index of the drawer when using theDrawerContainer.Tests:
ZIndexparameter of theDrawercomponent.