Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 22, 2025

add QueryAsync instance method

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5420

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

This pull request introduces a QueryAsync method to the SelectTable component, enabling programmatic data querying. It also includes a unit test for the new functionality.

New Features:

  • Added a QueryAsync method to the SelectTable component to allow triggering a data query programmatically.

Enhancements:

  • The SelectTable component now stores a reference to the internal Table component, allowing external access to its query functionality.

Tests:

  • Added a unit test for the new QueryAsync method to ensure it triggers the data query as expected.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 22, 2025

Reviewer's Guide by Sourcery

This pull request adds a QueryAsync instance method to the SelectTable component, enabling external triggering of data queries.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a QueryAsync method to the SelectTable component.
  • Added a public QueryAsync method to the SelectTable component to allow external triggering of the table's data query.
  • Added a private field _table to hold a reference to the internal Table component.
  • Assigned the _table field using @ref in the SelectTable.razor file.
src/BootstrapBlazor/Components/Select/SelectTable.razor.cs
src/BootstrapBlazor/Components/Select/SelectTable.razor
Added a unit test for the QueryAsync method.
  • Created a new unit test QueryAsync_Ok to verify the functionality of the QueryAsync method.
  • The test renders a SelectTable component and checks if the OnQueryAsync event is triggered when QueryAsync is called.
test/UnitTest/Components/SelectTableTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5420 Add a QueryAsync method to the SelectTable component to allow manual data updates.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 22, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 22, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Feb 22, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a non-null check for _table in QueryAsync to avoid potential null reference exceptions.
  • The added test case could benefit from more specific assertions to ensure the QueryAsync method is functioning as expected.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (4065f44) to head (fe718cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5422   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         646      646           
  Lines       29398    29406    +8     
  Branches     4133     4133           
=======================================
+ Hits        29360    29368    +8     
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-Authored-By: NullJutsu <[email protected]>
@ArgoZhang ArgoZhang merged commit f3463e5 into main Feb 22, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-select-table branch February 22, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(SelectTable): QueryAsync Support for manual refresh

2 participants