-
-
Notifications
You must be signed in to change notification settings - Fork 365
refactor(CacheList): prevent null item cause exception #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Sequence diagram for deleting a cache entrysequenceDiagram
participant CacheList Component
participant CacheManager
CacheList Component->>CacheList Component: OnDelete(key)
alt key is ICacheEntry
CacheList Component->>CacheManager: Clear(entry.Key)
CacheManager-->>CacheList Component: void
CacheList Component->>CacheList Component: UpdateCacheList()
CacheList Component-->>CacheList Component: void
else key is not ICacheEntry
CacheList Component-->>CacheList Component: void
end
Updated class diagram for CacheListclassDiagram
class CacheList {
-List~object?~ _cacheList
+OnInitialized()
-OnDelete(object key)
-OnDeleteAll()
-OnRefresh()
-UpdateCacheList()
-GetKey(object data) string
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
CacheManager.GetCacheEntryinstead ofTryGetCacheEntryfollowed by a null check. - The
UpdateCacheListmethod could be simplified by directly filtering null values within theSelectmethod.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5430 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29351 29351
Branches 4130 4130
=========================================
Hits 29351 29351 ☔ View full report in Codecov by Sentry. |
prevent null item cause exception
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5429
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request addresses an issue in the CacheList component where null items in the cache could cause exceptions. The fix involves filtering out null entries when updating the cache list, preventing the exception and improving the component's robustness.
Bug Fixes:
Enhancements: