-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Select): compatible enum value as Items #5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe Select component now correctly handles enum values, allowing them to be used directly as items. Additionally, the TryConvertTo method in ObjectExtensions has been updated. Sequence diagram for Select component with enum valuessequenceDiagram
participant SelectComponent
participant Rows
SelectComponent->>SelectComponent: GetSelectedRow()
SelectComponent->>SelectComponent: GetItemWidthEnumValue()
alt ValueType.IsEnum is true
SelectComponent->>Rows: Find(i => i.Value == Convert.ToInt32(Value).ToString())
Rows-->>SelectComponent: SelectedItem or null
else ValueType.IsEnum is false
SelectComponent-->>SelectComponent: null
end
alt SelectedItem found via enum value
SelectComponent-->>SelectComponent: Return SelectedItem
else SelectedItem not found via enum value
SelectComponent->>SelectComponent: Rows.Find(i => i.Value == CurrentValueAsString)
Rows-->>SelectComponent: SelectedItem or null
alt SelectedItem found via CurrentValueAsString
SelectComponent-->>SelectComponent: Return SelectedItem
else SelectedItem not found via CurrentValueAsString
SelectComponent->>SelectComponent: Rows.Find(i => i.Active)
Rows-->>SelectComponent: SelectedItem or null
alt SelectedItem found via Active
SelectComponent-->>SelectComponent: Return SelectedItem
else SelectedItem not found via Active
SelectComponent->>SelectComponent: Rows.FirstOrDefault(i => !i.IsDisabled)
Rows-->>SelectComponent: SelectedItem or null
alt SelectedItem found via IsDisabled
SelectComponent-->>SelectComponent: Return SelectedItem
else SelectedItem not found via IsDisabled
SelectComponent->>SelectComponent: GetVirtualizeItem(CurrentValueAsString)
SelectComponent-->>SelectComponent: SelectedItem or null
SelectComponent-->>SelectComponent: Return SelectedItem or null
end
end
end
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5434 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29351 29355 +4
Branches 4130 4131 +1
=========================================
+ Hits 29351 29355 +4 ☔ View full report in Codecov by Sentry. |
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to specifically cover the enum value scenario.
- The null-conditional operator could be removed from
GetRowsBySearchsince the null check is already performed in the FilterBySearchText method.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
compatible enum value as Items
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5431
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request enhances the Select component to be compatible with enum values used as Items. It also refactors the search functionality to use a more concise syntax.
Bug Fixes:
Enhancements: