-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(AutoComplete): OnEnterAsync/OnEscAsync not work #5474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #5467 by updating the Sequence diagram for enhanced JavaScript functionality in AutoCompletesequenceDiagram
participant User
participant AutoCompleteComponent
participant JavaScript
User->>AutoCompleteComponent: Keyup event (Enter/Escape)
AutoCompleteComponent->>JavaScript: handlerKeyup
JavaScript->>AutoCompleteComponent: invokeMethodAsync('EnterCallback', input.value) on Enter
JavaScript->>AutoCompleteComponent: invokeMethodAsync('EscCallback') on Escape
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5474 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 646 646
Lines 29373 29373
Branches 4134 4134
=========================================
Hits 29373 29373 ☔ View full report in Codecov by Sentry. |
Link issues
fixes #5467
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary of the changes
This pull request includes several changes to the
BootstrapBlazorproject, focusing on updating the project version, improving theAutoCompletecomponent, and enhancing JavaScript functionality. The most important changes are summarized below:Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated project version from9.4.2to9.4.3-beta01.AutoComplete Component Enhancements:
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs: Modified theRowsproperty andTriggerFiltermethod to use the new list slicing syntax ([.. Items]) instead ofToList(). [1] [2]JavaScript Functionality Enhancements:
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js: Enhanced thehandlerKeyupfunction to includeinvokein the destructured object and added asynchronous method invocations forEnterCallbackandEscCallback. [1] [2]Summary by Sourcery
Fix the OnEnterAsync and OnEscAsync callbacks in the AutoComplete component and enhance its performance by using list slicing syntax. Update the project version to 9.4.3-beta01 and improve JavaScript functionality with asynchronous method invocations.
Bug Fixes:
Enhancements: