fix(AutoComplete): trigger onBlur when clicking outside #5476

ArgoZhang · 2025-03-01T01:44:45Z

Link issues

fixes #5475

Regression?

Yes
No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

High
Medium
Low

[Justify the selection above]

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary of the changes

Summary by Sourcery

Bug Fixes:

Fixes an issue where the AutoComplete component does not trigger the onBlur event when clicking outside of the component.

Summary by Sourcery

Bug Fixes:

Fixes an issue where the AutoComplete component does not trigger the onBlur event when clicking outside of the component.

sourcery-ai · 2025-03-01T01:44:50Z

Reviewer's Guide by Sourcery

This pull request fixes an issue where the AutoComplete component was not triggering the onBlur event when clicking outside of the component. The fix involves adding a blur event listener to the input element, removing the menu click handler, and moving the blur logic to the key event handlers. A new property was added to control blur triggering.

Sequence diagram for AutoComplete onBlur event triggering

sequenceDiagram
    participant User
    participant AutoCompleteInput as Input
    participant AutoCompleteMenu as Menu
    participant Blazor

    User->>Input: Clicks outside
    activate Input
    Input-->>User: blur event
    deactivate Input
    Input->>Blazor: TriggerBlur()
    activate Blazor
    Blazor-->>Input: Response
    deactivate Blazor

Sequence diagram for AutoComplete Enter key press

sequenceDiagram
    participant User
    participant AutoCompleteInput as Input
    participant AutoCompleteMenu as Menu
    participant Blazor

    User->>Input: Presses Enter
    activate Input
    Input->>Menu: current.click()
    activate Menu
    Menu-->>Input: Response
    deactivate Menu
    Input->>Input: blur()
    Input-->>User: blur event
    deactivate Input
    Input->>Blazor: EnterCallback(input.value)
    activate Blazor
    Blazor-->>Input: Response
    deactivate Blazor

Sequence diagram for AutoComplete Escape key press

sequenceDiagram
    participant User
    participant AutoCompleteInput as Input
    participant AutoCompleteMenu as Menu
    participant Blazor

    User->>Input: Presses Escape
    activate Input
    Input->>Input: blur()
    Input-->>User: blur event
    deactivate Input
    Input->>Blazor: EscCallback()
    activate Blazor
    Blazor-->>Input: Response
    deactivate Blazor

File-Level Changes

Change	Details	Files
Added blur event listener to the input element to handle clicks outside the AutoComplete component.	Added a 'blur' event listener to the input element in the init function. When the input loses focus, the dropdown is closed. The 'TriggerBlur' method is invoked to trigger the blur event. Added a new attribute 'data-bb-blur' to control blur triggering.	`src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js`
Removed menu click handler and moved blur logic to key event handlers.	Removed the 'click' event listener from the menu element. Moved the blur logic to the 'Enter' and 'Escape' key event handlers. The input element now blurs when 'Enter' or 'Escape' is pressed.	`src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js`
Added a new property to control blur triggering.	Added a new property `TriggerBlurString` to control blur triggering based on the presence of `OnBlurAsync` event. Added `data-bb-blur` attribute to the input element in AutoComplete and Search components.	`src/BootstrapBlazor/Components/AutoComplete/PopoverCompleteBase.cs` `src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor` `src/BootstrapBlazor/Components/Search/Search.razor`
Updated project file to include new component files.	No functional changes, only updates to the project file.	`src/BootstrapBlazor/BootstrapBlazor.csproj`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5475	The `OnBlurAsync` event of the `AutoComplete` component should trigger when clicking outside the component.	✅

Possibly linked issues

bug(AutoComplete): trigger OnBlurAsync when clicking outside #5475: The PR fixes the bug described in the issue by triggering the onBlur event when clicking outside the AutoComplete component.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

codecov · 2025-03-01T01:47:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88ca87b) to head (42b4bf2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5476   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          646       646           
  Lines        29373     29374    +1     
  Branches      4134      4135    +1     
=========================================
+ Hits         29373     29374    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang · 2025-03-01T03:12:34Z

@sourcery-ai review

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

The javascript changes look good, but I'm not sure I understand why the menu click handler was removed.
Consider adding a comment to explain the purpose of the data-bb-blur attribute.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

fix(AutoComplete): should trigger onBlur when click body

0620132

chore: bump version 9.4.3-beta02

4398d92

sourcery-ai bot reviewed Mar 1, 2025

View reviewed changes

ArgoZhang added 5 commits March 1, 2025 10:07

perf: 优化性能

eb54308

refactor: Esc 优化性能

fe7e343

refactor: 更新 blur 事件

d26fdd5

refactor: Search 组件更新

7d62158

refactor: 精简逻辑代码

2f128fe

ArgoZhang changed the title ~~fix(AutoComplete): should trigger onBlur when click body~~ fix(AutoComplete): should trigger onBlur when clicking outside Mar 1, 2025

ArgoZhang changed the title ~~fix(AutoComplete): should trigger onBlur when clicking outside~~ fix(AutoComplete): trigger onBlur when clicking outside Mar 1, 2025

bb-auto bot assigned ArgoZhang Mar 1, 2025

bb-auto bot added the bug Something isn't working label Mar 1, 2025

bb-auto bot added this to the v9.4.0 milestone Mar 1, 2025

refactor: 移除 menu click 提高性能

42b4bf2

ArgoZhang enabled auto-merge (squash) March 1, 2025 03:12

sourcery-ai bot approved these changes Mar 1, 2025

View reviewed changes

ArgoZhang merged commit 53e11b8 into main Mar 1, 2025
6 checks passed

ArgoZhang deleted the fix-auto branch March 1, 2025 03:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(AutoComplete): trigger onBlur when clicking outside #5476

fix(AutoComplete): trigger onBlur when clicking outside #5476

Uh oh!

ArgoZhang commented Mar 1, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Mar 1, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Mar 1, 2025 •

edited

Loading

Uh oh!

ArgoZhang commented Mar 1, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(AutoComplete): trigger onBlur when clicking outside #5476

fix(AutoComplete): trigger onBlur when clicking outside #5476

Uh oh!

Conversation

ArgoZhang commented Mar 1, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary of the changes

Summary by Sourcery

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Sequence diagram for AutoComplete onBlur event triggering

Sequence diagram for AutoComplete Enter key press

Sequence diagram for AutoComplete Escape key press

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ArgoZhang commented Mar 1, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Mar 1, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 1, 2025 •

edited

Loading

codecov bot commented Mar 1, 2025 •

edited

Loading