refactor(AutoComplete): redesign blur logic

[ArgoZhang]

Link issues

fixes #5498

Summary By Copilot

This pull request includes several changes to the AutoComplete component in the src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js file. The main goal is to improve the handling of blur events and ensure proper cleanup during disposal. The most important changes include the introduction of a triggerBlur function, modifications to event handling, and updates to the dispose function.

Improvements to blur event handling:

• Introduced the triggerBlur function to handle blur events more consistently. This function is now called in various event handlers to ensure the dropdown menu is properly hidden. [1] [2] [3] [4]

Event handling updates:

• Added an event handler for the click event on the dropdown menu items to trigger the triggerBlur function.
• Modified the keyup event handler to call triggerBlur instead of directly blurring the input element. [1] [2]

Cleanup improvements:

• Updated the dispose function to include the menu element and ensure all event handlers are properly removed. [1] [2]

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

• High
• Medium
• Low

[Justify the selection above]

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Refactors the AutoComplete component's blur logic to improve consistency and ensure proper cleanup during disposal. Introduces a triggerBlur function and updates event handling to manage blur events more effectively. Also, updates the dispose function to properly remove event handlers.

Enhancements:

• Improves blur event handling by introducing a triggerBlur function that is called in various event handlers.
• Updates the dispose function to include the menu element and ensure all event handlers are properly removed.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the blur logic of the AutoComplete component by introducing a triggerBlur function, updating event handlers to use this function, and improving the disposal logic to ensure proper cleanup of resources. The changes primarily affect the AutoComplete.razor.js file.

Sequence diagram for dispose function

sequenceDiagram
    participant AutoComplete
    participant EventHandler
    participant Popover
    participant Input
    participant Menu
    participant BootstrapBlazor

    AutoComplete->>Popover: dispose(popover)
    alt popover exists
        Popover->>Input: dispose(input)
    end
    AutoComplete->>EventHandler: off(input, 'change')
    AutoComplete->>EventHandler: off(input, 'keyup')
    AutoComplete->>EventHandler: off(menu, 'click')
    AutoComplete->>BootstrapBlazor: AutoComplete.dispose(id, callback)
    BootstrapBlazor->>EventHandler: off(document, 'click', closePopover)

Loading

File-Level Changes

Change	Details	Files
Introduced a triggerBlur function to handle blur events more consistently.	Added triggerBlur function to remove the 'show' class from the element and conditionally invoke the 'TriggerBlur' method based on the 'data-bb-blur' attribute. Added a click event handler to menu items to call triggerBlur.	src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js
Modified event handlers to use the new triggerBlur function instead of directly manipulating the input element.	Replaced direct input.blur() calls in the keyup event handler with calls to triggerBlur. Replaced direct input.blur() calls in the Esc key handling with calls to triggerBlur.	src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js
Updated the dispose function to properly remove event handlers and dispose of resources.	Added the menu element to the disposal logic. Removed the 'blur' event handler from the input element. Removed the 'click' event handler from the menu element.	src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5498	Redesign the blur logic of the AutoComplete component to improve its behavior.	✅

Possibly linked issues

• refactor(AutoComplete): redesign blur logic #5498: The PR directly addresses the issue by fixing the blur event handling in the AutoComplete component. The changes ensure the OnBlurAsync event triggers correctly when clicking outside the form.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding comments to the triggerBlur function and other key parts of the code to explain the purpose and behavior.
• It might be helpful to include a brief explanation of why the blur logic needed to be redesigned in the PR description.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (98115a9) to head (5a24f5e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5499   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29563     29563           
  Branches      4165      4165           
=========================================
  Hits         29563     29563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.