-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(registerBootstrapBlazorModule): reset init field when items is empty #5528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the project version and modifies the Sequence diagram for registerBootstrapBlazorModule with empty itemssequenceDiagram
participant JS
participant BootstrapBlazorModule
participant DotNetCallback
JS->>BootstrapBlazorModule: registerBootstrapBlazorModule(name, identifier, callback)
BootstrapBlazorModule->>BootstrapBlazorModule: this._items.filter(item => item !== id)
alt this._items.length === 0 && cb
BootstrapBlazorModule->>BootstrapBlazorModule: this._init = false
BootstrapBlazorModule->>DotNetCallback: cb()
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great to see the version number updated in the project file.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5528 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29583 29583
Branches 4167 4167
=========================================
Hits 29583 29583 ☔ View full report in Codecov by Sentry. |
Link issues
[请在下方 # 后面填写相关 Issue 编号,如 #42]
fixes #5527
Summary By Copilot
This pull request includes changes to the
BootstrapBlazorproject to update the version and improve the utility module. The most important changes include updating the project version and modifying theregisterBootstrapBlazorModulefunction to reset the_initproperty.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.4.5-beta01to9.4.5.Utility module improvement:
src/BootstrapBlazor/wwwroot/modules/utility.js: Modified theregisterBootstrapBlazorModulefunction to reset the_initproperty when the_itemsarray is empty and a callback is provided.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: