Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Mar 6, 2025

Link issues

fixes #5548
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]

Summary By Copilot

This pull request includes changes to the Modals.razor and Modal.razor.js files to improve modal functionality and code consistency. The most important changes include removing the maximize button from draggable modals, cleaning up the modal close event handling, and ensuring consistent handling of the modal's original style.

Improvements to modal functionality and code consistency:

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]
[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Refactors the Modal component to improve code consistency and remove unnecessary code. This includes removing the maximize button from draggable modals and cleaning up event handling.

Enhancements:

  • Removes the maximize button from draggable modals.
  • Cleans up modal close event handling.
  • Ensures consistent handling of the modal's original style.

@bb-auto bb-auto bot added the enhancement New feature or request label Mar 6, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 6, 2025

Reviewer's Guide by Sourcery

This pull request refactors the Modal component by removing the dialog variable and making improvements to modal functionality and code consistency. The changes include removing the maximize button from draggable modals, cleaning up the modal close event handling, and ensuring consistent handling of the modal's original style.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the maximize button from draggable modals.
  • Removed the ShowMaximizeButton attribute from the ModalDialog component when IsDraggable is set to true.
src/BootstrapBlazor.Server/Components/Samples/Modals.razor
Cleaned up the modal close event handling.
  • Removed unnecessary conditions and event listeners related to draggable modals in the hidden.bs.modal event handler.
src/BootstrapBlazor/Components/Modal/Modal.razor.js
Ensured consistent handling of the modal's original style.
  • Changed the condition checks for modal.originalStyle from void 0 to null for consistency in the backupBodyStyle and restoreBodyStyle functions.
src/BootstrapBlazor/Components/Modal/Modal.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#5548 Remove the dialog variable from the Modal component.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.4.0 milestone Mar 6, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

@ArgoZhang ArgoZhang enabled auto-merge (squash) March 6, 2025 07:51
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f93cb6f) to head (7c6ba93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5549   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29607     29607           
  Branches      4173      4173           
=========================================
  Hits         29607     29607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang disabled auto-merge March 6, 2025 08:01
@ArgoZhang ArgoZhang merged commit 82c936c into main Mar 6, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-modal branch March 6, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Modal): remove dialog variable

2 participants