feat(UniverIcon): add UniverIcon component #5557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces the new UniverIcon component to the BootstrapBlazor project. It includes the addition of new layout and sample components, updates to project configuration and localization files, and styling adjustments. The implementation involves creating new Razor components for displaying the icons, adding a package reference for the UniverIcon library, and incorporating the new icons into the application's menu and styling. Class diagram for UniverIcon componentclassDiagram
class UniverIcon {
+string Name
+RenderFragment ChildContent
}
class UniverIcons
class IconLayout
class UniverIconList {
}
UniverIcons -- UniverIconList : Uses
UniverIconList -- UniverIcon : Uses
IconLayout <|-- MainLayout : Inherits
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider generating the UniverIconList.razor file from a list of icon names to avoid manual maintenance.
- The styling updates in site.css could be placed in a dedicated CSS file for the UniverIcon component.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor.Server/Components/Samples/Icons/UniverIcons.razor
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5557 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 649 649
Lines 29605 29605
Branches 4172 4172
===========================================
+ Hits 29602 29605 +3
+ Misses 2 0 -2
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@sourcery-ai review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5556
Summary By Copilot
This pull request introduces a new UniverIcon component to the BootstrapBlazor project. The changes include adding new files for the component, updating localization files, and modifying the project configuration to include the new package.
New component addition:
src/BootstrapBlazor.Server/Components/Layout/IconLayout.razor: Added a new layout component for icons.src/BootstrapBlazor.Server/Components/Layout/IconLayout.razor.cs: Created a partial class for the IconLayout component.src/BootstrapBlazor.Server/Components/Samples/Icons/UniverIcons.razor: Added a new page for UniverIcons with localization and example usage.src/BootstrapBlazor.Server/Components/Samples/Icons/UniverIcons.razor.cs: Created a partial class for the UniverIcons component.Project configuration:
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj: Added a package reference forBootstrapBlazor.UniverIconversion 9.0.1.Localization updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Added localization entries for UniverIcons in English. [1] [2]src/BootstrapBlazor.Server/Locales/zh-CN.json: Added localization entries for UniverIcons in Chinese. [1] [2]Menu updates:
src/BootstrapBlazor.Server/Extensions/MenusLocalizerExtensions.cs: Added a new menu item for UniverIcons.Styling updates:
src/BootstrapBlazor.Server/wwwroot/css/site.css: Added styles for the icon list display.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds a new UniverIcon component to the BootstrapBlazor project, including a sample page to showcase the icons.
New Features: