-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(Icons): add click to copy to clipboard function #5566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request renames the Sequence diagram for click to copy functionalitysequenceDiagram
participant User
participant IconDiv as Icon
participant Tooltip
User->>Icon: Clicks on Icon
activate Icon
Icon->>Tooltip: Sets tooltip content to 'Copy'
activate Tooltip
deactivate Tooltip
Icon->>Icon: Copies icon value to clipboard
Icon->>Tooltip: Sets timeout to revert tooltip
activate Tooltip
Tooltip-->>Icon: After 1 second
deactivate Tooltip
Icon->>Tooltip: Sets tooltip content to original title
activate Tooltip
deactivate Tooltip
deactivate Icon
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider if BootstrapIconBase is the right name, or if it should be something more descriptive of its purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5566 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29605 29605
Branches 4172 4172
=========================================
Hits 29605 29605 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5565
Summary By Copilot
This pull request includes several changes to rename the
BootstrapIconclass and its related files toBootstrapIconBaseand update the corresponding references across the project. Additionally, it updates localization files to reflect the new namespace structure for icon components.Class and File Renaming:
BootstrapIconclass toBootstrapIconBaseand updated the corresponding JS module loader attribute. (src/BootstrapBlazor.Server/Components/Samples/Icons/BootstrapIconBase.razor.cs)BootstrapIcon.razor.jstoBootstrapIconBase.razor.jsand updated the file content accordingly. (src/BootstrapBlazor.Server/Components/Samples/Icons/BootstrapIconBase.razor.js)Component Updates:
@inheritsdirective in various Razor component files to useBootstrapIconBaseinstead ofBootstrapIcon. [1] [2] [3] [4] [5]Localization Updates:
en-US.jsonandzh-CN.jsonto reflect the new namespace structure for icon components. (src/BootstrapBlazor.Server/Locales/en-US.json,src/BootstrapBlazor.Server/Locales/zh-CN.json) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Renames BootstrapIcon to BootstrapIconBase and updates related files and localization keys.
Enhancements: