-
-
Notifications
You must be signed in to change notification settings - Fork 363
revert(ListView): remove scroll class #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request primarily reverts a change in the ListView component by removing the 'scroll' class from the accordion-body, likely to address a layout issue. Additionally, the project version has been updated from 9.4.7 to 9.4.8. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation of why the
scrollclass was removed in the commit message.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29605 29605
Branches 4172 4172
=========================================
Hits 29605 29605 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5571
Summary By Copilot
This pull request includes updates to the project version and a minor change to the
ListViewcomponent.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.4.7to9.4.8.Component improvement:
src/BootstrapBlazor/Components/ListView/ListView.razor: Removed thescrollclass from theaccordion-bodydiv to improve the layout.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Reverts the removal of the scroll class from the accordion-body div in the ListView component and updates the project version.
Bug Fixes:
Chores: