-
-
Notifications
You must be signed in to change notification settings - Fork 363
chore(Script): downgrade script syntax #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the theme switching logic to use the center position of the element, updates JavaScript modules to use logical OR assignment, and adjusts CSS animations for view transitions. The changes improve the visual effects of theme switching and modernize the JavaScript syntax. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
|
@sourcery-ai review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5582 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29623 29623
Branches 4170 4170
=========================================
Hits 29623 29623 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5581
Summary By Copilot
This pull request includes updates to package versions in the
BootstrapBlazor.Serverproject and minor code changes to improve compatibility and readability. The most important changes include updating package versions in the project files and replacing the nullish coalescing assignment operator with a logical OR assignment in JavaScript files.Package Version Updates:
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj: Updated versions forBootstrapBlazor.Html2Image,BootstrapBlazor.MeiliSearch,BootstrapBlazor.MindMap, andBootstrapBlazor.UniverSheetpackages. [1] [2] [3]src/BootstrapBlazor/BootstrapBlazor.csproj: Updated project version to9.4.9-beta03.Code Improvements:
src/BootstrapBlazor/Components/Typed/Typed.razor.js: Replaced the nullish coalescing assignment operator with a logical OR assignment for theoptionsvariable.src/BootstrapBlazor/wwwroot/modules/fullscreen.js: Replaced the nullish coalescing assignment operator with a logical OR assignment for theoptionsvariable.src/BootstrapBlazor/wwwroot/modules/utility.js: Replaced the nullish coalescing assignment operator with a logical OR assignment for thewindow.BootstrapBlazorobject.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactors the theme switching logic to calculate the center position of the element clicked and pass it to the switchTheme function. This provides a better visual effect when switching themes. Additionally, the javascript syntax is downgraded to support older browsers.
Enhancements: