-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(Translation): translate comments and documentation from Chinese to English #5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request translates comments and documentation from Chinese to English across multiple attribute classes in the Updated class diagram for PlaceHolderAttributeclassDiagram
class PlaceHolderAttribute {
+string Text
PlaceHolderAttribute(string placeholder)
}
note for PlaceHolderAttribute "Comments translated from Chinese to English."
note for PlaceHolderAttribute "Improved the constructor for better readability."
Updated class diagram for TabItemOptionAttributeclassDiagram
class TabItemOptionAttribute {
+string? Text
+bool Closable
+string? Icon
}
note for TabItemOptionAttribute "Comments translated from Chinese to English."
Updated class diagram for AutoGenerateBaseAttributeclassDiagram
class AutoGenerateBaseAttribute {
+bool Ignore
+bool Readonly
+bool Visible
+bool Sortable
+bool Filterable
+bool Searchable
+bool TextWrap
+bool TextEllipsis
+Alignment Align
+bool ShowTips
+bool ShowCopyColumn
}
note for AutoGenerateBaseAttribute "Comments translated from Chinese to English."
Updated class diagram for BootstrapModuleAutoLoaderAttributeclassDiagram
class BootstrapModuleAutoLoaderAttribute {
+string? ModuleName
}
BootstrapModuleAutoLoaderAttribute --|> JSModuleAutoLoaderAttribute : extends
note for BootstrapModuleAutoLoaderAttribute "Comments translated from Chinese to English."
Updated class diagram for AutoGenerateClassAttributeclassDiagram
class AutoGenerateClassAttribute {
}
AutoGenerateClassAttribute --|> AutoGenerateBaseAttribute : extends
note for AutoGenerateClassAttribute "Comments translated from Chinese to English."
Updated class diagram for TableMetadataForAttributeclassDiagram
class TableMetadataForAttribute {
+Type DataType
}
note for TableMetadataForAttribute "Comments translated from Chinese to English."
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a tool like a spell checker to ensure the translations are accurate and natural-sounding.
- It would be helpful to have someone who is fluent in both Chinese and English review the translations.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5604 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29625 29622 -3
Branches 4165 4165
=========================================
- Hits 29625 29622 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5603
Summary By Copilot
This pull request includes updates to several attribute classes in the
BootstrapBlazorlibrary to improve code readability and consistency by translating comments and documentation from Chinese to English.Documentation Translation:
src/BootstrapBlazor/Attributes/AutoGenerateBaseAttribute.cs: Translated comments and documentation to English to improve readability for non-Chinese speakers.src/BootstrapBlazor/Attributes/AutoGenerateClassAttribute.cs: Updated comments to English for better understanding.src/BootstrapBlazor/Attributes/AutoGenerateColumnAttribute.cs: Translated all comments and documentation to English, and replaced some<inheritdoc/>tags with explicit descriptions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]src/BootstrapBlazor/Attributes/BootstrapModuleAutoLoaderAttribute.cs: Translated constructor and property comments to English.src/BootstrapBlazor/Attributes/JSModuleAutoLoaderAttribute.cs: Updated parameter and property comments to English for clarity.src/BootstrapBlazor/Attributes/NullableBoolItemsAttribute.cs: Translated comments to English.src/BootstrapBlazor/Attributes/PlaceHolderAttribute.cs: Translated comments and improved the constructor for better readability.src/BootstrapBlazor/Attributes/TabItemOptionAttribute.cs: Translated comments to English for better understanding.src/BootstrapBlazor/Attributes/TableMetadataForAttribute.cs: Updated comments to English.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Documentation: