feat(ModalSettings): add ModalSettings on BootstrapBlazorOptions #5619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces ModalSettings to BootstrapBlazorOptions, allowing for centralized configuration of modal components. It also updates the IsFade property to be nullable, providing more flexibility in controlling fade animations. Additionally, the project version has been updated. Updated class diagram for BootstrapBlazorOptions and ModalSettingsclassDiagram
class BootstrapBlazorOptions {
+TableSettings TableSettings
+ModalSettings ModalSettings
+StepSettings StepSettings
+ConnectionHubOptions ConnectionHubOptions
+WebClientOptions WebClientOptions
+IpLocatorOptions IpLocatorOptions
+ScrollOptions ScrollOptions
+ContextMenuOptions ContextMenuOptions
+CacheManagerOptions CacheManagerOptions
}
class ModalSettings {
+bool? IsFade
}
BootstrapBlazorOptions o-- ModalSettings : has a
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a default constructor to
ModalSettingsto ensure a non-null instance. - The introduction of
ModalSettingsand the nullableIsFadeproperty seem reasonable, but ensure that all usages ofIsFadecorrectly handle the null case to avoid unexpected behavior.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5619 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 650 +1
Lines 29622 29626 +4
Branches 4165 4166 +1
=========================================
+ Hits 29622 29626 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5618
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on updating versioning, modifying fade animation properties, and adding new configuration settings for modal components. The most important changes include updating the project version, changing theIsFadeproperty to nullable, and introducingModalSettingsto manage modal component configurations.Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated project version from9.4.9-beta05to9.4.9-beta06.Fade Animation Property Changes:
src/BootstrapBlazor/Components/Dialog/Dialog.razor.cs: Changed the_isFadeproperty frombooltobool?.src/BootstrapBlazor/Components/Dialog/DialogOption.cs: Changed theIsFadeproperty frombooltobool?.src/BootstrapBlazor/Components/Modal/Modal.razor.cs: Changed theIsFadeproperty frombooltobool?and updated theClassStringmethod to use the newGetIsFadeValuemethod fromBootstrapBlazorOptions. [1] [2]New Configuration Settings:
src/BootstrapBlazor/Options/ModalSettings.cs: Added a newModalSettingsclass with anIsFadeproperty to manage modal component settings.src/BootstrapBlazor/Options/BootstrapBlazorOptions.cs: Added aModalSettingsproperty to theBootstrapBlazorOptionsclass.src/BootstrapBlazor/Extensions/BootstrapBlazorOptionsExtensions.cs: Added a new methodGetIsFadeValueto retrieve theIsFadevalue fromModalSettings.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Configures modal components via BootstrapBlazorOptions, allowing control over fade animations. Updates the project version and modifies fade animation properties to be nullable for more flexible configuration.
Enhancements: