feat(MultiSelect): redesign IsFixedSearch function #5651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request redesigns the Updated class diagram for SelectBaseclassDiagram
class SelectBase {
+bool ShowSearch
+bool IsFixedSearch
+string SearchIcon
+string NoDataTip
+string NoSearchDataText
+string DropdownMenuClassString
}
Updated class diagram for SelectclassDiagram
class Select {
-string DropdownMenuClassString
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a sample to showcase the new
IsFixedSearchfunctionality. - The commit history could be improved by squashing the commits into a single commit with a descriptive message.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5651 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 653 653
Lines 29393 29387 -6
Branches 4195 4197 +2
=========================================
- Hits 29393 29387 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5650
Summary By Copilot
This pull request includes significant updates to the
MultiSelectandSelectcomponents, focusing on enhancing the search functionality and refactoring related code. Key changes include the addition of new parameters, updates to the rendering logic, and adjustments to the unit tests to reflect these updates.Enhancements to Search Functionality:
src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor: Added new search-related UI elements and updated the layout to include toggles forShowSearchandIsFixedSearch.src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor.cs: Introduced new boolean fields_isFixedSearchand_showSearchto manage the search behavior.Updates to MultiSelect Component:
src/BootstrapBlazor/Components/Select/MultiSelect.razor: Modified the rendering logic to conditionally display search elements and handle empty search results. [1] [2]src/BootstrapBlazor/Components/Select/MultiSelect.razor.cs: Removed theSearchClassStringproperty and updated theDropdownMenuClassStringproperty to include search-related classes.Updates to Select Component:
src/BootstrapBlazor/Components/Select/Select.razor: Adjusted the search input rendering and added handling for empty search results.src/BootstrapBlazor/Components/Select/Select.razor.cs: Removed theIsFixedSearchparameter and updated theDropdownMenuClassStringproperty to reflect the new search logic. [1] [2] [3]Refactoring and Code Cleanup:
src/BootstrapBlazor/Components/Select/SelectBase.cs: Added theIsFixedSearchparameter and updated theDropdownMenuClassStringproperty to handle fixed search scenarios. [1] [2]src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor: Updated the search input rendering and empty search result handling. [1] [2] [3]src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.cs: Removed theIsFixedSearchparameter and updated related methods to use new search logic. [1] [2] [3] [4] [5] [6]Unit Test Adjustments:
test/UnitTest/Components/MultiSelectTest.cs: Added tests to verify the toolbar visibility based on the presence of data.test/UnitTest/Components/SelectGenericTest.cs: Updated tests to reflect changes in the search-related class names.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactors the search functionality in the MultiSelect and Select components to improve usability and code maintainability. The changes include UI enhancements, code cleanup, and updates to unit tests.
Enhancements: