-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(MultiSelect): support ShowToolbar parameter when set ShowSearch to true #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a Sequence diagram for MultiSelect component with ShowToolbarsequenceDiagram
participant User
participant MultiSelect Component
User->>MultiSelect Component: Selects an item
activate MultiSelect Component
MultiSelect Component->>MultiSelect Component: Updates selected values
MultiSelect Component->>MultiSelect Component: Renders toolbar with buttons (if ShowToolbar is true)
MultiSelect Component-->>User: Updates UI with selected items and toolbar
deactivate MultiSelect Component
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a sample to the demo page that showcases the new
ShowToolbarfeature with custom buttons via theButtonTemplate. - The SCSS changes introduce a lot of new variables; ensure these are consistently used and documented.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5655 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 654
Lines 29571 29576 +5
Branches 4207 4208 +1
=========================================
+ Hits 29571 29576 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5645
Summary By Copilot
This pull request includes several changes to the BootstrapBlazor project, focusing on updating package versions, enhancing the MultiSelect component, and adding localization entries. The most important changes are grouped by theme below.
Package Updates:
BootstrapBlazor.DockViewpackage to version9.1.5inBootstrapBlazor.Server.csproj.MultiSelect Component Enhancements:
ShowToolbarproperty to theMultiSelectcomponent and updated the component to include a toolbar with default buttons. [1] [2] [3] [4] [5] [6] [7] [8] [9]MultiSelectcomponent's SCSS to support fixed toolbar and search box styles. [1] [2] [3] [4]Localization Additions:
ShowSearchandIsFixedSearchattributes inen-US.jsonandzh-CN.json. [1] [2] [3]Project Version Update:
9.5.0-beta03inBootstrapBlazor.csproj.Code Refactoring:
DropdownMenuClassStringproperty inSelectBase.csto use the newCheckFixedSearchmethod. [1] [2]bootstrapblazor.scss.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds a ShowToolbar parameter to the MultiSelect component, allowing users to display a toolbar with default buttons when ShowSearch is enabled. This change also includes associated styling updates and localization entries.
New Features:
Enhancements: