Skip to content

refactor(TreeView): remove IsFixedSearch parameter #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

refactor(TreeView): remove IsFixedSearch parameter #5658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75829de
refactor: 移除 IsFixedSearch 参数
ArgoZhang Mar 19, 2025
5c1646f
test: 更新单元测试
ArgoZhang Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/BootstrapBlazor.Server/Components/Samples/TreeViews.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
// See the LICENSE file in the project root for more information.
// Maintainer: Argo Zhang([email protected]) Website: https://www.blazor.zone

using Microsoft.AspNetCore.Components.Rendering;
using Microsoft.AspNetCore.Components.Web;

namespace BootstrapBlazor.Server.Components.Samples;

/// <summary>
Expand Down
8 changes: 0 additions & 8 deletions src/BootstrapBlazor/Components/TreeView/TreeView.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// See the LICENSE file in the project root for more information.
// Maintainer: Argo Zhang([email protected]) Website: https://www.blazor.zone

using Microsoft.AspNetCore.Components.Web;
using Microsoft.Extensions.Localization;

namespace BootstrapBlazor.Components;
Expand All @@ -15,7 +14,6 @@ namespace BootstrapBlazor.Components;
public partial class TreeView<TItem> : IModelEqualityComparer<TItem>
{
private string? ClassString => CssBuilder.Default("tree-view")
.AddClass("is-fixed-search", ShowSearch && IsFixedSearch)
.AddClassFromAttributes(AdditionalAttributes)
.Build();

Expand Down Expand Up @@ -86,12 +84,6 @@ public partial class TreeView<TItem> : IModelEqualityComparer<TItem>
[Parameter]
public bool ShowSearch { get; set; }

/// <summary>
/// Gets or sets whether the search bar is fixed. Default is false.
/// </summary>
[Parameter]
public bool IsFixedSearch { get; set; }

/// <summary>
/// Gets or sets whether to show the reset search button. Default is true.
/// </summary>
Expand Down
8 changes: 0 additions & 8 deletions test/UnitTest/Components/TreeViewTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
// See the LICENSE file in the project root for more information.
// Maintainer: Argo Zhang([email protected]) Website: https://www.blazor.zone

using System.Threading.Tasks;

namespace UnitTest.Components;

public class TreeViewTest : BootstrapBlazorTestBase
Expand Down Expand Up @@ -1051,12 +1049,6 @@ public void ShowSearch_Ok()
});
});
cut.Contains("search-template");

cut.SetParametersAndRender(pb =>
{
pb.Add(a => a.IsFixedSearch, true);
});
cut.Contains("is-fixed-search");
}

[Fact]
Expand Down
Loading