refactor(Select): remove IsFixedSearch parameter #5660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/BootstrapBlazor/Components/Select/SelectBase.cs
Contributor
Reviewer's Guide by SourceryThis pull request removes the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the obsolete properties entirely instead of just marking them as obsolete.
- Verify that the removal of
IsFixedSearchdoes not introduce any accessibility issues.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5660 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 654
Lines 29576 29542 -34
Branches 4208 4204 -4
=========================================
- Hits 29576 29542 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5659
Summary By Copilot
This pull request focuses on removing the
IsFixedSearchfeature from various components and updating related code and documentation. The most important changes include the removal ofIsFixedSearchfrom theMultiSelectandSelectcomponents, updates to localization files, and marking theIsFixedSearchWhenSelectproperty as obsolete.Removal of
IsFixedSearchfeature:src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor: Removed all instances ofIsFixedSearchfrom theMultiSelectcomponent. [1] [2] [3] [4] [5]src/BootstrapBlazor.Server/Components/Samples/Selects.razor: Removed all instances ofIsFixedSearchfrom theSelectcomponent. [1] [2] [3] [4]src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor.cs: Removed the_isFixedSearchfield and its related attribute. [1] [2]src/BootstrapBlazor.Server/Components/Samples/Selects.razor.cs: Removed the_isFixedSearchfield and its related attribute. [1] [2]Localization updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Removed theIsFixedSearchattribute description from the English localization file. [1] [2]src/BootstrapBlazor.Server/Locales/zh-CN.json: Removed theIsFixedSearchattribute description from the Chinese localization file. [1] [2]Marking
IsFixedSearchWhenSelectas obsolete:src/BootstrapBlazor/Attributes/AutoGenerateColumnAttribute.cs: Marked theIsFixedSearchWhenSelectproperty as obsolete.src/BootstrapBlazor/Components/EditorForm/EditorItem.cs: Marked theIsFixedSearchWhenSelectproperty as obsolete.src/BootstrapBlazor/Components/EditorForm/IEditorItem.cs: Marked theIsFixedSearchWhenSelectproperty as obsolete.src/BootstrapBlazor/Components/Filters/LookupFilter.razor.cs: Marked theIsFixedSearchproperty as obsolete.src/BootstrapBlazor/Components/Filters/TableFilter.razor: Removed theIsFixedSearchattribute from theLookupFiltercomponent.Codebase simplification:
src/BootstrapBlazor/Components/Select/MultiSelect.razor: Simplified theDropdownMenuClassStringproperty. [1] [2] [3]src/BootstrapBlazor/Components/Select/MultiSelect.razor.scss: Updated the CSS to remove references to fixed search height.src/BootstrapBlazor/Components/Select/Select.razor: Simplified the dropdown menu class.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Removes the
IsFixedSearchfeature from theMultiSelectandSelectcomponents, simplifying the codebase and updating related documentation and localization files. TheIsFixedSearchWhenSelectproperty is marked as obsolete.Enhancements:
IsFixedSearchproperty from theMultiSelectandSelectcomponents.Tests:
IsFixedSearchproperty.