feat(AutoFill): add IsVirtulize parameter #5664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces virtual scrolling support to the Sequence diagram for AutoFill with Virtualization and OnQueryAsyncsequenceDiagram
participant User
participant AutoFill Component
participant Virtualize Component
participant Data Source
User->>AutoFill Component: Enters text for filtering
AutoFill Component->>Virtualize Component: TriggerFilter(searchText)
Virtualize Component->>Data Source: OnQueryAsync(VirtualizeQueryOption)
Data Source-->>Virtualize Component: QueryData with items and total count
Virtualize Component->>AutoFill Component: ItemsProviderResult
AutoFill Component->>User: Renders filtered items
Updated class diagram for AutoComplete componentclassDiagram
class AutoComplete {
}
note for AutoComplete "Added shadow to the dropdown menu for better visual distinction."
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a loading indicator when
IsVirtualizeis enabled andOnQueryAsyncis used. - The demo code should showcase both
ItemsandOnQueryAsyncdata sources for theIsVirtualizefeature.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5664 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 654 654
Lines 29542 29681 +139
Branches 4204 4216 +12
==========================================
+ Hits 29542 29681 +139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5663
Summary By Copilot
This pull request includes several changes to enhance the functionality and user interface of the
BootstrapBlazorcomponents. The most important changes include the addition of virtual scrolling support, updates to localization files, and improvements to theAutoCompleteandAutoFillcomponents.Enhancements to Components:
AutoFill,MultiSelect, andSelectcomponents by introducing theIsVirtualizeproperty. This allows handling large datasets more efficiently. ([[1]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-c5d5ab295d4887ad9236507061a2f974df8e49dd7e09e4c37f2e754c3f722fd8R75-R142),[[2]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-9c197d1f062687015b933f8a75ef062a1e864d5e9e99d5dc31522f87da44a858R36-R44),[[3]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-66ded6d378824103dd1be66f7ef69a400ae390c6ef91922c06957256290cefbfR477-R484),[[4]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-f9acebf8daf7961532146196175320f775b3539b8518fa39c101ad7d3e6bfe1dR418-R425))Localization Updates:
[[1]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-790d42ebea731775f0fee88a92b20fadb044e53706fd6d3025dfa095df9b1b41L2156-R2158),[[2]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-790d42ebea731775f0fee88a92b20fadb044e53706fd6d3025dfa095df9b1b41L3031-R3034),[[3]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-790d42ebea731775f0fee88a92b20fadb044e53706fd6d3025dfa095df9b1b41L3207-R3211),[[4]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-746b8cc3c80dd10d0a1bf77b8d6571652e15bcc7c33dcac0954d93b1a728cc7fL2156-R2158),[[5]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-746b8cc3c80dd10d0a1bf77b8d6571652e15bcc7c33dcac0954d93b1a728cc7fL3031-R3034),[[6]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-746b8cc3c80dd10d0a1bf77b8d6571652e15bcc7c33dcac0954d93b1a728cc7fL3207-R3211))Component Improvements:
AutoComplete Component:
AutoCompletecomponent by adding a shadow to the dropdown menu for better visual distinction. ([[1]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-d7907c9240cf11222f4ab3e96b2d2f22f36fa0bc6422d99acea9de2748133930L26-R26),[[2]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-ff3e4641ea68928ba99380b62a108f794647be2ed8467bd58236bab40e9e05aaL3-L7),[[3]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-ff3e4641ea68928ba99380b62a108f794647be2ed8467bd58236bab40e9e05aaL18-R13))AutoFill Component:
AutoFillcomponent to support virtual scrolling and added new methods for custom filtering and querying data asynchronously. ([[1]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-c5d5ab295d4887ad9236507061a2f974df8e49dd7e09e4c37f2e754c3f722fd8L12-R13),[[2]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-9c197d1f062687015b933f8a75ef062a1e864d5e9e99d5dc31522f87da44a858R58-R60),[[3]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-9c197d1f062687015b933f8a75ef062a1e864d5e9e99d5dc31522f87da44a858R69-R89),[[4]](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-342511820cd79fb7947f85e2341e878a70f345e6db243e24567a33f1733e8c11R2))Project Configuration:
9.5.0-beta07to reflect the new changes and improvements. ([src/BootstrapBlazor/BootstrapBlazor.csprojL4-R4](https://github.com/dotnetcore/BootstrapBlazor/pull/5664/files#diff-07918ce1b66955e76da5cd0ffa38512cce984fa2a09735a60e0db37b45235527L4-R4))These changes collectively enhance the performance, usability, and internationalization of the
BootstrapBlazorcomponents.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds virtual scrolling support to the AutoFill, MultiSelect, and Select components via the IsVirtualize parameter. Also adds a clearable option to the AutoFill component and improves the AutoComplete component by adding a shadow to the dropdown menu.
New Features:
Tests: