-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(TreeView): add OverscanCount parameter #5673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the Updated class diagram for the TreeView componentclassDiagram
class TreeView {
+bool IsVirtualize
+float RowHeight
+int OverscanCount
}
note for TreeView "RowHeight default value changed from 38f to 29f\nOverscanCount parameter added with default value of 10"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change to the project version seems out of place; is it intentional?
- Consider adding a unit test for the new
OverscanCountparameter to ensure it functions as expected.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 654 654
Lines 29690 29691 +1
Branches 4216 4216
=======================================
+ Hits 29687 29688 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5672
Summary By Copilot
This pull request includes changes to the
BootstrapBlazorproject, focusing on version adjustment, improvements to theTreeViewcomponent, and cleanup in unit tests. The most important changes are listed below:Version Adjustment:
src/BootstrapBlazor/BootstrapBlazor.csprojfrom9.5.0-beta09to9.4.10.TreeView Component Improvements:
Virtualizecomponent insrc/BootstrapBlazor/Components/TreeView/TreeView.razorto use theOverscanCountproperty instead of a hardcoded value.TreeViewclass insrc/BootstrapBlazor/Components/TreeView/TreeView.razor.cs:RowHeightfor virtual scrolling from38fto29f.OverscanCountwith a default value of10for virtual scrolling.Unit Test Cleanup:
Task.Delaycalls in theOnCancel_Okmethod oftest/UnitTest/Components/TimerTest.csto streamline the test execution. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Configures the TreeView component's Virtualize component to use the OverscanCount property instead of a hardcoded value, and updates the default RowHeight. Also, this PR removes unnecessary Task.Delay calls in the TimerTest unit tests.
Enhancements: