-
-
Notifications
You must be signed in to change notification settings - Fork 364
test(Select): update unit test #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates a unit test to ensure the expected value in an assertion matches the actual value. Specifically, the expected value in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great you included a link to the issue this PR addresses.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 654
Lines 29689 29689
Branches 4216 4217 +1
=========================================
Hits 29689 29689 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5679
Summary By Copilot
This pull request includes a small change to the
test/UnitTest/Components/SelectTest.csfile. The change modifies the expected value in an assertion within theIsVirtualize_Items_Clearable_Oktest method to ensure it matches the actual value.test/UnitTest/Components/SelectTest.cs: Changed the expected value in the assertion from"Test2"to"2"in theIsVirtualize_Items_Clearable_Oktest method.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Tests: