feat(Tab): add ShowToolbar parameter #5691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces a toolbar to the Tab component, which includes refresh and fullscreen button options. It also refactors the Tab component to use a TabItemContent component for managing tab item content rendering. Additionally, the BootstrapBlazor.BootstrapIcon package version is updated, and the codebase is improved for clarity and consistency. Sequence diagram for refreshing a TabItemsequenceDiagram
participant Tab
participant TabItem
participant TabItemContent
Tab->>Tab: OnRefreshAsync()
Tab->>Tab: TabItems.FirstOrDefault(i => i.IsActive)
alt item is not null
Tab->>TabItem: Refresh(_cache)
TabItem->>TabItemContent: Render()
TabItemContent->>TabItemContent: _renderHandle.Render(BuildRenderTree)
end
Class diagram for TabToolbarRefreshButton componentclassDiagram
class TabToolbarRefreshButton {
string? Icon
Func<Task>? OnClickAsync
Task OnClick()
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5691 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 657 +3
Lines 29689 29770 +81
Branches 4213 4220 +7
=========================================
+ Hits 29689 29770 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5690
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on enhancing theTabcomponent by adding new features, improving existing functionality, and updating the codebase for better maintainability. The most important changes include adding toolbar support to theTabcomponent, updating the project dependencies, and refining the rendering logic.Enhancements to
Tabcomponent:Tabcomponent. (src/BootstrapBlazor/Components/Tab/Tab.razor,src/BootstrapBlazor/Components/Tab/Tab.razor.cs,src/BootstrapBlazor/Components/Tab/Tab.razor.scss) [1] [2] [3]TabItemContentclass for managing the content rendering of tab items. (src/BootstrapBlazor/Components/Tab/TabItemContent.cs)TabToolbarRefreshButtoncomponent to handle refresh functionality in the toolbar. (src/BootstrapBlazor/Components/Tab/TabToolbarRefreshButton.razor,src/BootstrapBlazor/Components/Tab/TabToolbarRefreshButton.razor.cs) [1] [2]Dependency updates:
BootstrapBlazor.BootstrapIconpackage version from9.0.1to9.0.2. (src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj)Codebase improvements:
Tab.razor. (src/BootstrapBlazor/Components/Tab/Tab.razor) [1] [2]Tab.razor.cs. (src/BootstrapBlazor/Components/Tab/Tab.razor.cs) [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds a toolbar to the Tab component with refresh and fullscreen button options.
New Features:
Tests: